fix: remove unnecessary inheritAttrs prop

varletjs · Jul 8, 2021 · 91d9503 · 91d9503
1 parent 72522ba
commit 91d9503
Show file tree

Hide file tree

Showing 4 changed files with 3 additions and 8 deletions.
diff --git a/packages/varlet-ui/src/checkbox-group/CheckboxGroup.vue b/packages/varlet-ui/src/checkbox-group/CheckboxGroup.vue
@@ -1,5 +1,5 @@
 <template>
-  <div class="var-checkbox-group__wrap" v-bind="$attrs">
+  <div class="var-checkbox-group__wrap">
     <div class="var-checkbox-group" :class="[`var-checkbox-group--${direction}`]">
       <slot />
     </div>
@@ -24,7 +24,6 @@ export default defineComponent({
   components: {
     [FormDetails.name]: FormDetails,
   },
-  inheritAttrs: false,
   props,
   setup(props) {
     const max: ComputedRef<number | string | undefined> = computed(() => props.max)

diff --git a/packages/varlet-ui/src/icon/Icon.vue b/packages/varlet-ui/src/icon/Icon.vue
@@ -15,7 +15,6 @@
       fontSize: toSizeUnit(size),
     }"
     :src="isURL(name) ? nextName : null"
-    v-bind="$attrs"
     @click="onClick"
   />
 </template>
@@ -29,7 +28,6 @@ import type { Ref } from 'vue'
 
 export default defineComponent({
   name: 'VarIcon',
-  inheritAttrs: false,
   props,
   setup(props) {
     const nextName: Ref<string | undefined> = ref('')

diff --git a/packages/varlet-ui/src/row/Row.vue b/packages/varlet-ui/src/row/Row.vue
@@ -5,7 +5,6 @@
       justifyContent: justify,
       alignItems: align
     }"
-    v-bind="$attrs"
     @click="onClick"
   >
     <slot />
@@ -22,7 +21,6 @@ import type { RowProvider } from './provide'
 
 export default defineComponent({
   name: 'VarRow',
-  inheritAttrs: false,
   props,
   setup(props) {
     const { cols, bindCols, length } = useCols()

diff --git a/packages/varlet-ui/src/uploader/Uploader.vue b/packages/varlet-ui/src/uploader/Uploader.vue
@@ -72,8 +72,8 @@
         x5-video-player-type="h5"
         x5-video-player-fullscreen="false"
         controls
-        :src="currentPreview.url"
-        v-if="currentPreview && isHTMLSupportVideo(currentPreview.url)"
+        :src="currentPreview?.url"
+        v-if="currentPreview && isHTMLSupportVideo(currentPreview?.url)"
       ></video>
     </var-popup>
   </div>