Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v3 - fetch employees data #767

Open
wants to merge 4 commits into
base: v3
Choose a base branch
from
Open

Conversation

mathiazom
Copy link
Contributor

@mathiazom mathiazom commented Oct 11, 2024

Very basic Proof of Concept for fetching external data for the employees page section.

The section can be added to any dynamic page (aka pageBuilder)

image

Copy link

vercel bot commented Oct 11, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
variant-no ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 24, 2024 11:40am
variant-se-2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 24, 2024 11:40am

@mathiazom mathiazom force-pushed the feat/v3-fetch-employees-data branch 2 times, most recently from ad4a67a to 5dbf2e7 Compare October 11, 2024 14:07
@mathiazom mathiazom requested a review from anemne October 14, 2024 06:15
@trulshj
Copy link
Contributor

trulshj commented Oct 22, 2024

An important concern here is that individual employees should have control over whether or not their phone number should be shown as contact info. This is probably something that should be part of Chewbacca and controlled through dash.variant.no so not something that is directly implementable here, but important to design for this possibility.

@mathiazom
Copy link
Contributor Author

An important concern here is that individual employees should have control over whether or not their phone number should be shown as contact info. This is probably something that should be part of Chewbacca and controlled through dash.variant.no so not something that is directly implementable here, but important to design for this possibility.

How about filtering this out when constructing the Chewbacca response? We would then only need to handle missing values, i.e. having them as optional in employee type.

Base automatically changed from feat/v3-employees-page to v3 October 24, 2024 11:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants