Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Protobuf cleanup #423

Closed
holtgrewe opened this issue Aug 1, 2024 · 0 comments · Fixed by #425
Closed

Protobuf cleanup #423

holtgrewe opened this issue Aug 1, 2024 · 0 comments · Fixed by #425
Labels
enhancement New feature or request

Comments

@holtgrewe
Copy link
Contributor

Is your feature request related to a problem? Please describe.
Protobuf best practices (e.g., SCREAMING_SNAKE_CASE, having an UNDEFINED = 0 first value) are not thoroughly employed.

Describe the solution you'd like

  • implemenent validation, see clinvar-this for details
  • fix issues uncovered by linter

Describe alternatives you've considered
N/A

Additional context
@holtgrewe holtgrewe added the enhancement New feature or request label Aug 1, 2024
holtgrewe added a commit that referenced this issue Aug 5, 2024
@holtgrewe
feat!: cleanup protobufs to best practices (#423)
396f89f
@holtgrewe holtgrewe linked a pull request Aug 5, 2024 that will close this issue
feat!: cleanup protobufs to best practices (#423) #425
Merged
holtgrewe added a commit that referenced this issue Aug 5, 2024
@holtgrewe
feat!: cleanup protobufs to best practices (#423) (#425)
48a3144 
Release-As: 0.13.0
@varfish-bot varfish-bot mentioned this issue Aug 5, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat!: cleanup protobufs to best practices (#423) varfish-org/varfish-server-worker
1 participant
@holtgrewe