Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: refactory query schema to use protobuf (#374) #419

Merged
merged 24 commits into from
Aug 5, 2024
Merged

Conversation

jakibaki
Copy link
Contributor

Solves #374 and #375. Continuation of #398.

@jakibaki jakibaki requested a review from holtgrewe July 29, 2024 09:19
Copy link

codecov bot commented Jul 29, 2024

Codecov Report

Attention: Patch coverage is 89.31075% with 183 lines in your changes missing coverage. Please review.

Project coverage is 75%. Comparing base (71de822) to head (2a570ee).
Report is 3 commits behind head on main.

Files Patch % Lines
src/seqvars/query/interpreter/genotype.rs 90% 48 Missing ⚠️
src/seqvars/query/schema/query.rs 95% 30 Missing ⚠️
src/seqvars/query/mod.rs 68% 29 Missing ⚠️
src/seqvars/query/output/variant_related.rs 0% 20 Missing ⚠️
src/seqvars/query/interpreter/clinvar.rs 0% 11 Missing ⚠️
src/seqvars/query/interpreter/regions_allowlist.rs 0% 11 Missing ⚠️
src/seqvars/query/schema/data.rs 93% 11 Missing ⚠️
src/seqvars/query/interpreter/quality.rs 92% 10 Missing ⚠️
src/seqvars/query/annonars.rs 0% 6 Missing ⚠️
src/seqvars/query/interpreter/mod.rs 0% 5 Missing ⚠️
... and 2 more
Additional details and impacted files
@@         Coverage Diff          @@
##           main   #419    +/-   ##
====================================
- Coverage    80%    75%    -6%     
====================================
  Files        43     44     +1     
  Lines      6329   7180   +851     
====================================
+ Hits       5109   5432   +323     
- Misses     1220   1748   +528     
Files Coverage Δ
src/seqvars/ingest/header.rs 84% <100%> (+<1%) ⬆️
src/seqvars/ingest/mod.rs 87% <100%> (-1%) ⬇️
src/seqvars/prefilter/mod.rs 85% <ø> (-1%) ⬇️
src/seqvars/query/interpreter/consequences.rs 92% <100%> (ø)
src/seqvars/query/interpreter/frequency.rs 100% <100%> (ø)
src/seqvars/query/interpreter/genes_allowlist.rs 100% <100%> (ø)
src/seqvars/query/output/gene_related.rs 0% <ø> (-94%) ⬇️
src/seqvars/query/sorting.rs 0% <ø> (-50%) ⬇️
src/strucvars/query/mod.rs 54% <ø> (-1%) ⬇️
src/strucvars/txt_to_bin/masked.rs 90% <ø> (-4%) ⬇️
... and 13 more

... and 11 files with indirect coverage changes

@holtgrewe holtgrewe changed the title Refactor internal data structures of seqvar query schema and introduce protobuf schema feat!: refactory query schema to use protobuf (#374) Aug 5, 2024
holtgrewe
holtgrewe previously approved these changes Aug 5, 2024
@holtgrewe holtgrewe enabled auto-merge (squash) August 5, 2024 11:26
@holtgrewe holtgrewe merged commit 0e14e16 into main Aug 5, 2024
7 of 8 checks passed
@holtgrewe holtgrewe deleted the emily/protobuf branch August 5, 2024 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants