Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unify names in strucvar filtration background database exac/gnomad #307

Closed
holtgrewe opened this issue Feb 27, 2024 · 0 comments · Fixed by #308
Closed

Unify names in strucvar filtration background database exac/gnomad #307

holtgrewe opened this issue Feb 27, 2024 · 0 comments · Fixed by #308
Labels
enhancement New feature or request

Comments

@holtgrewe
Copy link
Contributor

Is your feature request related to a problem? Please describe.
The names "exac" and "gnomad" are ambiguous now in the context of gnomAD SV.

Describe the solution you'd like
Rather, rename to gnomad_exomes and gnomad_genomes for consistency with seqvars.

Describe alternatives you've considered
N/A

Additional context

  • This will require adjusting varfish-server as well.
@holtgrewe holtgrewe added the enhancement New feature or request label Feb 27, 2024
holtgrewe added a commit that referenced this issue Feb 27, 2024
@holtgrewe
feat: unify database names in strucvar filtration (#307)
879f480
@holtgrewe holtgrewe linked a pull request Feb 27, 2024 that will close this issue
feat: unify names in strucvar filtration background database exac/gnomad (#307) #308
Merged
holtgrewe added a commit that referenced this issue Feb 27, 2024
@holtgrewe
feat: unify database names in strucvar filtration (#307)
5d444da
@holtgrewe holtgrewe mentioned this issue Feb 27, 2024
Closed
holtgrewe added a commit that referenced this issue Feb 27, 2024
@holtgrewe
feat: unify database names in strucvar filtration (#307) (#308)
43413d4
@github-project-automation github-project-automation bot moved this from To triage to Done in Release Planning Feb 27, 2024
@varfish-bot varfish-bot mentioned this issue Feb 27, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
Release Planning
Archived in project
Milestone
No milestone
1 participant
@holtgrewe