Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: skip REF-only records #576

Merged
merged 4 commits into from
Oct 11, 2024

follow vcf spec 4.5 §5.5

d93246a
Select commit
Loading
Failed to load commit list.
Sign in for the full log view
Merged

fix: skip REF-only records #576

follow vcf spec 4.5 §5.5
d93246a
Select commit
Loading
Failed to load commit list.
GitHub Actions / clippy succeeded Oct 11, 2024 in 0s

clippy

2 warnings

Details

Results

Message level Amount
Internal compiler error 0
Error 0
Warning 2
Note 0
Help 0

Versions

  • rustc 1.81.0 (eeb90cda1 2024-09-04)
  • cargo 1.81.0 (2dbb1af80 2024-08-20)
  • clippy 0.1.81 (eeb90cd 2024-09-04)

Annotations

Check warning on line 103 in src/server/mod.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

this `match` can be collapsed into the outer `if let`

warning: this `match` can be collapsed into the outer `if let`
   --> src/server/mod.rs:97:9
    |
97  | /         match level {
98  | |             log::Level::Trace | log::Level::Debug => {
99  | |                 std::env::set_var("RUST_LOG", "debug");
100 | |                 env_logger::init_from_env(env_logger::Env::new().default_filter_or("info"));
101 | |             }
102 | |             _ => (),
103 | |         }
    | |_________^
    |
help: the outer pattern can be modified to include the inner pattern
   --> src/server/mod.rs:96:17
    |
96  |     if let Some(level) = args_common.verbose.log_level() {
    |                 ^^^^^ replace this binding
97  |         match level {
98  |             log::Level::Trace | log::Level::Debug => {
    |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ with this pattern
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match
    = note: `#[warn(clippy::collapsible_match)]` on by default

Check warning on line 2963 in src/annotate/strucvars/mod.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

taken reference of right operand

warning: taken reference of right operand
    --> src/annotate/strucvars/mod.rs:2963:16
     |
2963 |             || record.alternate_bases().as_ref() == &["<*>".to_string()]
     |                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^--------------------
     |                                                     |
     |                                                     help: use the right value directly: `["<*>".to_string()]`
     |
     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref
     = note: `#[warn(clippy::op_ref)]` on by default