Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Allow '.' genotypes #178

Merged
merged 5 commits into from
Sep 18, 2023
Merged

fix: Allow '.' genotypes #178

merged 5 commits into from
Sep 18, 2023

Conversation

xiamaz
Copy link
Contributor

@xiamaz xiamaz commented Sep 15, 2023

This currently only contains a test with the offending vcf line. This will close #177

@xiamaz xiamaz changed the title Certain genotypes crash mehari fix: Allow '.' genotypes Sep 15, 2023
@xiamaz xiamaz marked this pull request as ready for review September 15, 2023 21:42
@xiamaz xiamaz requested a review from holtgrewe September 15, 2023 21:43
@codecov
Copy link

codecov bot commented Sep 15, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.42% 🎉

Comparison is base (f7ec775) 76.36% compared to head (5490449) 76.79%.
Report is 28 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #178      +/-   ##
==========================================
+ Coverage   76.36%   76.79%   +0.42%     
==========================================
  Files          16       16              
  Lines        3982     3995      +13     
==========================================
+ Hits         3041     3068      +27     
+ Misses        941      927      -14     
Files Changed Coverage Δ
src/annotate/seqvars/mod.rs 68.76% <100.00%> (+2.55%) ⬆️

... and 4 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@holtgrewe holtgrewe merged commit 6d0c5b8 into main Sep 18, 2023
@holtgrewe holtgrewe deleted the 177-vcf-crash branch September 18, 2023 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

vcf entry crashes mehari
2 participants