Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace flatbuffers by protocolbuffers/prost #15

Closed
holtgrewe opened this issue Mar 21, 2023 · 2 comments · Fixed by #57
Closed

Replace flatbuffers by protocolbuffers/prost #15

holtgrewe opened this issue Mar 21, 2023 · 2 comments · Fixed by #57

Comments

@holtgrewe
Copy link
Contributor

While flatbuffers allows to load data only partially, this does not really work when having to put it into an Rc<...> for passing it to the hgvs library.

By this benchmark we should evaluate the bincode crate as well.
@holtgrewe
Copy link
Contributor Author

Also, rkyv is interesting.

@holtgrewe holtgrewe changed the title Evalute bincode as flatbuffers alternative Replace flatbuffers by protocolbuffers/prost Apr 21, 2023
@holtgrewe
Copy link
Contributor Author

The the rust serialization benchmark, it looks like prost is a very promising alternative.

First of all, we get protocolbuffers goodness with schema evolution (in principle). Further, other languages would be able to also read our files.

holtgrewe added a commit that referenced this issue Apr 21, 2023
@holtgrewe
feat: switch from flatbuffers to protobuf (#15)
be3ef8e
@holtgrewe holtgrewe linked a pull request Apr 21, 2023 that will close this issue
feat: switch from flatbuffers to protobuf (#15) #57
Merged
holtgrewe added a commit that referenced this issue Apr 21, 2023
@holtgrewe
feat: switch from flatbuffers to protobuf (#15) (#57)
3fe3322
@github-actions github-actions bot mentioned this issue Apr 21, 2023
Merged
holtgrewe added a commit that referenced this issue Apr 24, 2023
@holtgrewe
feat: switch from flatbuffers to protobuf (#15) (#57)
b75e5e7
holtgrewe added a commit that referenced this issue Apr 24, 2023
@holtgrewe
feat: switch from flatbuffers to protobuf (#15) (#57)
c16ffa6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: switch from flatbuffers to protobuf (#15) varfish-org/mehari
1 participant
@holtgrewe