chore: make get_tx return a reference #867
tedilAnnotations
22 warnings
|
empty line after doc comment:
src/verify/seqvars.rs#L36
warning: empty line after doc comment
--> src/verify/seqvars.rs:36:5
|
36 | / /// Path to output TSV file.
37 | |
| |_
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#empty_line_after_doc_comments
= help: if the empty line is unintentional remove it
|
|
empty line after doc comment:
src/verify/seqvars.rs#L32
warning: empty line after doc comment
--> src/verify/seqvars.rs:32:5
|
32 | / /// Path to the reference FASTA file.
33 | |
| |_
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#empty_line_after_doc_comments
= note: `#[warn(clippy::empty_line_after_doc_comments)]` on by default
= help: if the empty line is unintentional remove it
|
|
the following explicit lifetimes could be elided: 'de:
/home/runner/work/mehari/mehari/target/debug/build/mehari-bd4d3cce3bf8a43a/out/mehari.txs.serde.rs#L1755
warning: the following explicit lifetimes could be elided: 'de
--> /home/runner/work/mehari/mehari/target/debug/build/mehari-bd4d3cce3bf8a43a/out/mehari.txs.serde.rs:1755:22
|
1755 | impl<'de> serde::de::Visitor<'de> for GeneratedVisitor {
| ^^^ ^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
help: elide the lifetimes
|
1755 - impl<'de> serde::de::Visitor<'de> for GeneratedVisitor {
1755 + impl serde::de::Visitor<'_> for GeneratedVisitor {
|
|
|
the following explicit lifetimes could be elided: 'de:
/home/runner/work/mehari/mehari/target/debug/build/mehari-bd4d3cce3bf8a43a/out/mehari.txs.serde.rs#L1637
warning: the following explicit lifetimes could be elided: 'de
--> /home/runner/work/mehari/mehari/target/debug/build/mehari-bd4d3cce3bf8a43a/out/mehari.txs.serde.rs:1637:14
|
1637 | impl<'de> serde::de::Visitor<'de> for GeneratedVisitor {
| ^^^ ^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
help: elide the lifetimes
|
1637 - impl<'de> serde::de::Visitor<'de> for GeneratedVisitor {
1637 + impl serde::de::Visitor<'_> for GeneratedVisitor {
|
|
|
the following explicit lifetimes could be elided: 'de:
/home/runner/work/mehari/mehari/target/debug/build/mehari-bd4d3cce3bf8a43a/out/mehari.txs.serde.rs#L1536
warning: the following explicit lifetimes could be elided: 'de
--> /home/runner/work/mehari/mehari/target/debug/build/mehari-bd4d3cce3bf8a43a/out/mehari.txs.serde.rs:1536:22
|
1536 | impl<'de> serde::de::Visitor<'de> for GeneratedVisitor {
| ^^^ ^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
help: elide the lifetimes
|
1536 - impl<'de> serde::de::Visitor<'de> for GeneratedVisitor {
1536 + impl serde::de::Visitor<'_> for GeneratedVisitor {
|
|
|
the following explicit lifetimes could be elided: 'de:
/home/runner/work/mehari/mehari/target/debug/build/mehari-bd4d3cce3bf8a43a/out/mehari.txs.serde.rs#L1442
warning: the following explicit lifetimes could be elided: 'de
--> /home/runner/work/mehari/mehari/target/debug/build/mehari-bd4d3cce3bf8a43a/out/mehari.txs.serde.rs:1442:14
|
1442 | impl<'de> serde::de::Visitor<'de> for GeneratedVisitor {
| ^^^ ^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
help: elide the lifetimes
|
1442 - impl<'de> serde::de::Visitor<'de> for GeneratedVisitor {
1442 + impl serde::de::Visitor<'_> for GeneratedVisitor {
|
|
|
the following explicit lifetimes could be elided: 'de:
/home/runner/work/mehari/mehari/target/debug/build/mehari-bd4d3cce3bf8a43a/out/mehari.txs.serde.rs#L1266
warning: the following explicit lifetimes could be elided: 'de
--> /home/runner/work/mehari/mehari/target/debug/build/mehari-bd4d3cce3bf8a43a/out/mehari.txs.serde.rs:1266:22
|
1266 | impl<'de> serde::de::Visitor<'de> for GeneratedVisitor {
| ^^^ ^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
help: elide the lifetimes
|
1266 - impl<'de> serde::de::Visitor<'de> for GeneratedVisitor {
1266 + impl serde::de::Visitor<'_> for GeneratedVisitor {
|
|
|
the following explicit lifetimes could be elided: 'de:
/home/runner/work/mehari/mehari/target/debug/build/mehari-bd4d3cce3bf8a43a/out/mehari.txs.serde.rs#L1089
warning: the following explicit lifetimes could be elided: 'de
--> /home/runner/work/mehari/mehari/target/debug/build/mehari-bd4d3cce3bf8a43a/out/mehari.txs.serde.rs:1089:14
|
1089 | impl<'de> serde::de::Visitor<'de> for GeneratedVisitor {
| ^^^ ^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
help: elide the lifetimes
|
1089 - impl<'de> serde::de::Visitor<'de> for GeneratedVisitor {
1089 + impl serde::de::Visitor<'_> for GeneratedVisitor {
|
|
|
the following explicit lifetimes could be elided: 'de:
/home/runner/work/mehari/mehari/target/debug/build/mehari-bd4d3cce3bf8a43a/out/mehari.txs.serde.rs#L964
warning: the following explicit lifetimes could be elided: 'de
--> /home/runner/work/mehari/mehari/target/debug/build/mehari-bd4d3cce3bf8a43a/out/mehari.txs.serde.rs:964:22
|
964 | impl<'de> serde::de::Visitor<'de> for GeneratedVisitor {
| ^^^ ^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
help: elide the lifetimes
|
964 - impl<'de> serde::de::Visitor<'de> for GeneratedVisitor {
964 + impl serde::de::Visitor<'_> for GeneratedVisitor {
|
|
|
the following explicit lifetimes could be elided: 'de:
/home/runner/work/mehari/mehari/target/debug/build/mehari-bd4d3cce3bf8a43a/out/mehari.txs.serde.rs#L830
warning: the following explicit lifetimes could be elided: 'de
--> /home/runner/work/mehari/mehari/target/debug/build/mehari-bd4d3cce3bf8a43a/out/mehari.txs.serde.rs:830:14
|
830 | impl<'de> serde::de::Visitor<'de> for GeneratedVisitor {
| ^^^ ^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
help: elide the lifetimes
|
830 - impl<'de> serde::de::Visitor<'de> for GeneratedVisitor {
830 + impl serde::de::Visitor<'_> for GeneratedVisitor {
|
|
|
the following explicit lifetimes could be elided: 'de:
/home/runner/work/mehari/mehari/target/debug/build/mehari-bd4d3cce3bf8a43a/out/mehari.txs.serde.rs#L729
warning: the following explicit lifetimes could be elided: 'de
--> /home/runner/work/mehari/mehari/target/debug/build/mehari-bd4d3cce3bf8a43a/out/mehari.txs.serde.rs:729:22
|
729 | impl<'de> serde::de::Visitor<'de> for GeneratedVisitor {
| ^^^ ^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
help: elide the lifetimes
|
729 - impl<'de> serde::de::Visitor<'de> for GeneratedVisitor {
729 + impl serde::de::Visitor<'_> for GeneratedVisitor {
|
|
|
the following explicit lifetimes could be elided: 'de:
/home/runner/work/mehari/mehari/target/debug/build/mehari-bd4d3cce3bf8a43a/out/mehari.txs.serde.rs#L627
warning: the following explicit lifetimes could be elided: 'de
--> /home/runner/work/mehari/mehari/target/debug/build/mehari-bd4d3cce3bf8a43a/out/mehari.txs.serde.rs:627:14
|
627 | impl<'de> serde::de::Visitor<'de> for GeneratedVisitor {
| ^^^ ^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
help: elide the lifetimes
|
627 - impl<'de> serde::de::Visitor<'de> for GeneratedVisitor {
627 + impl serde::de::Visitor<'_> for GeneratedVisitor {
|
|
|
the following explicit lifetimes could be elided: 'de:
/home/runner/work/mehari/mehari/target/debug/build/mehari-bd4d3cce3bf8a43a/out/mehari.txs.serde.rs#L498
warning: the following explicit lifetimes could be elided: 'de
--> /home/runner/work/mehari/mehari/target/debug/build/mehari-bd4d3cce3bf8a43a/out/mehari.txs.serde.rs:498:22
|
498 | impl<'de> serde::de::Visitor<'de> for GeneratedVisitor {
| ^^^ ^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
help: elide the lifetimes
|
498 - impl<'de> serde::de::Visitor<'de> for GeneratedVisitor {
498 + impl serde::de::Visitor<'_> for GeneratedVisitor {
|
|
|
the following explicit lifetimes could be elided: 'de:
/home/runner/work/mehari/mehari/target/debug/build/mehari-bd4d3cce3bf8a43a/out/mehari.txs.serde.rs#L331
warning: the following explicit lifetimes could be elided: 'de
--> /home/runner/work/mehari/mehari/target/debug/build/mehari-bd4d3cce3bf8a43a/out/mehari.txs.serde.rs:331:22
|
331 | impl<'de> serde::de::Visitor<'de> for GeneratedVisitor {
| ^^^ ^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
help: elide the lifetimes
|
331 - impl<'de> serde::de::Visitor<'de> for GeneratedVisitor {
331 + impl serde::de::Visitor<'_> for GeneratedVisitor {
|
|
|
the following explicit lifetimes could be elided: 'de:
/home/runner/work/mehari/mehari/target/debug/build/mehari-bd4d3cce3bf8a43a/out/mehari.txs.serde.rs#L158
warning: the following explicit lifetimes could be elided: 'de
--> /home/runner/work/mehari/mehari/target/debug/build/mehari-bd4d3cce3bf8a43a/out/mehari.txs.serde.rs:158:22
|
158 | impl<'de> serde::de::Visitor<'de> for GeneratedVisitor {
| ^^^ ^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
help: elide the lifetimes
|
158 - impl<'de> serde::de::Visitor<'de> for GeneratedVisitor {
158 + impl serde::de::Visitor<'_> for GeneratedVisitor {
|
|
|
the following explicit lifetimes could be elided: 'de:
/home/runner/work/mehari/mehari/target/debug/build/mehari-bd4d3cce3bf8a43a/out/mehari.txs.serde.rs#L29
warning: the following explicit lifetimes could be elided: 'de
--> /home/runner/work/mehari/mehari/target/debug/build/mehari-bd4d3cce3bf8a43a/out/mehari.txs.serde.rs:29:14
|
29 | impl<'de> serde::de::Visitor<'de> for GeneratedVisitor {
| ^^^ ^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
help: elide the lifetimes
|
29 - impl<'de> serde::de::Visitor<'de> for GeneratedVisitor {
29 + impl serde::de::Visitor<'_> for GeneratedVisitor {
|
|
|
the following explicit lifetimes could be elided: 'de:
/home/runner/work/mehari/mehari/target/debug/build/mehari-bd4d3cce3bf8a43a/out/mehari.server.serde.rs#L199
warning: the following explicit lifetimes could be elided: 'de
--> /home/runner/work/mehari/mehari/target/debug/build/mehari-bd4d3cce3bf8a43a/out/mehari.server.serde.rs:199:22
|
199 | impl<'de> serde::de::Visitor<'de> for GeneratedVisitor {
| ^^^ ^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
help: elide the lifetimes
|
199 - impl<'de> serde::de::Visitor<'de> for GeneratedVisitor {
199 + impl serde::de::Visitor<'_> for GeneratedVisitor {
|
|
|
the following explicit lifetimes could be elided: 'de:
/home/runner/work/mehari/mehari/target/debug/build/mehari-bd4d3cce3bf8a43a/out/mehari.server.serde.rs#L70
warning: the following explicit lifetimes could be elided: 'de
--> /home/runner/work/mehari/mehari/target/debug/build/mehari-bd4d3cce3bf8a43a/out/mehari.server.serde.rs:70:22
|
70 | impl<'de> serde::de::Visitor<'de> for GeneratedVisitor {
| ^^^ ^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
= note: `#[warn(clippy::needless_lifetimes)]` on by default
help: elide the lifetimes
|
70 - impl<'de> serde::de::Visitor<'de> for GeneratedVisitor {
70 + impl serde::de::Visitor<'_> for GeneratedVisitor {
|
|
|
writing `&Vec` instead of `&[_]` involves a new object where a slice will do:
src/db/subset/mod.rs#L241
warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do
--> src/db/subset/mod.rs:241:19
|
241 | gene_symbols: &Vec<String>,
| ^^^^^^^^^^^^ help: change this to: `&[String]`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
|
|
writing `&Vec` instead of `&[_]` involves a new object where a slice will do:
src/db/subset/mod.rs#L228
warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do
--> src/db/subset/mod.rs:228:21
|
228 | transcript_ids: &Vec<String>,
| ^^^^^^^^^^^^ help: change this to: `&[String]`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
= note: `#[warn(clippy::ptr_arg)]` on by default
|
|
elided lifetime has a name:
src/common/noodles.rs#L79
warning: elided lifetime has a name
--> src/common/noodles.rs:79:24
|
76 | async fn records<'a>(
| -- lifetime `'a` declared here
...
79 | ) -> LocalBoxStream<std::io::Result<RecordBuf>> {
| ^ this elided lifetime gets resolved as `'a`
|
|
elided lifetime has a name:
src/common/noodles.rs#L63
warning: elided lifetime has a name
--> src/common/noodles.rs:63:24
|
60 | async fn records<'a>(
| -- lifetime `'a` declared here
...
63 | ) -> LocalBoxStream<std::io::Result<RecordBuf>>;
| ^ this elided lifetime gets resolved as `'a`
|
= note: `#[warn(elided_named_lifetimes)]` on by default
|