ci: do not fail if codecov submission fails (#174) #126
clippy
14 warnings
Details
Results
Message level | Amount |
---|---|
Internal compiler error | 0 |
Error | 0 |
Warning | 14 |
Note | 0 |
Help | 0 |
Versions
- rustc 1.78.0 (9b00956e5 2024-04-29)
- cargo 1.78.0 (54d8815d0 2024-03-26)
- clippy 0.1.78 (9b00956 2024-04-29)
Annotations
Check warning on line 497 in src/parser/ds.rs
github-actions / clippy
use of a fallible conversion when an infallible one could be used
warning: use of a fallible conversion when an infallible one could be used
--> src/parser/ds.rs:497:18
|
497 | .try_into()
| ^^^^^^^^ help: use: `into`
|
= note: converting `RnaInterval` to `Range<i32>` cannot fail
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_fallible_conversions
Check warning on line 490 in src/parser/ds.rs
github-actions / clippy
use of a fallible conversion when an infallible one could be used
warning: use of a fallible conversion when an infallible one could be used
--> src/parser/ds.rs:490:18
|
490 | .try_into()
| ^^^^^^^^ help: use: `into`
|
= note: converting `TxInterval` to `Range<i32>` cannot fail
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_fallible_conversions
= note: `#[warn(clippy::unnecessary_fallible_conversions)]` on by default
Check warning on line 1007 in src/mapper/altseq.rs
github-actions / clippy
assigning the result of `Clone::clone()` may be inefficient
warning: assigning the result of `Clone::clone()` may be inefficient
--> src/mapper/altseq.rs:1007:17
|
1007 | alternative = insertion.clone();
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use `clone_from()`: `alternative.clone_from(insertion)`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assigning_clones
Check warning on line 992 in src/mapper/altseq.rs
github-actions / clippy
assigning the result of `Clone::clone()` may be inefficient
warning: assigning the result of `Clone::clone()` may be inefficient
--> src/mapper/altseq.rs:992:17
|
992 | alternative = reference.clone();
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use `clone_from()`: `alternative.clone_from(&reference)`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assigning_clones
Check warning on line 941 in src/mapper/altseq.rs
github-actions / clippy
assigning the result of `Clone::clone()` may be inefficient
warning: assigning the result of `Clone::clone()` may be inefficient
--> src/mapper/altseq.rs:941:17
|
941 | alternative = insertion.clone();
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use `clone_from()`: `alternative.clone_from(insertion)`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assigning_clones
Check warning on line 916 in src/mapper/altseq.rs
github-actions / clippy
assigning the result of `Clone::clone()` may be inefficient
warning: assigning the result of `Clone::clone()` may be inefficient
--> src/mapper/altseq.rs:916:13
|
916 | reference = deletion.clone();
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use `clone_from()`: `reference.clone_from(deletion)`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assigning_clones
Check warning on line 912 in src/mapper/altseq.rs
github-actions / clippy
assigning the result of `Clone::clone()` may be inefficient
warning: assigning the result of `Clone::clone()` may be inefficient
--> src/mapper/altseq.rs:912:13
|
912 | alternative = insertion.clone();
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use `clone_from()`: `alternative.clone_from(insertion)`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assigning_clones
Check warning on line 911 in src/mapper/altseq.rs
github-actions / clippy
assigning the result of `ToOwned::to_owned()` may be inefficient
warning: assigning the result of `ToOwned::to_owned()` may be inefficient
--> src/mapper/altseq.rs:911:13
|
911 | reference = "".to_owned();
| ^^^^^^^^^^^^^^^^^^^^^^^^^ help: use `clone_into()`: `"".clone_into(&mut reference)`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assigning_clones
Check warning on line 880 in src/mapper/altseq.rs
github-actions / clippy
assigning the result of `ToOwned::to_owned()` may be inefficient
warning: assigning the result of `ToOwned::to_owned()` may be inefficient
--> src/mapper/altseq.rs:880:13
|
880 | reference = "".to_owned();
| ^^^^^^^^^^^^^^^^^^^^^^^^^ help: use `clone_into()`: `"".clone_into(&mut reference)`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assigning_clones
Check warning on line 861 in src/mapper/altseq.rs
github-actions / clippy
assigning the result of `ToOwned::to_owned()` may be inefficient
warning: assigning the result of `ToOwned::to_owned()` may be inefficient
--> src/mapper/altseq.rs:861:13
|
861 | reference = "".to_owned();
| ^^^^^^^^^^^^^^^^^^^^^^^^^ help: use `clone_into()`: `"".clone_into(&mut reference)`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assigning_clones
= note: `#[warn(clippy::assigning_clones)]` on by default
Check warning on line 60 in src/mapper/alignment.rs
github-actions / clippy
writing `&Vec` instead of `&[_]` involves a new object where a slice will do
warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do
--> src/mapper/alignment.rs:60:30
|
60 | pub fn build_tx_cigar(exons: &Vec<TxExonsRecord>, strand: i16) -> Result<CigarString, Error> {
| ^^^^^^^^^^^^^^^^^^^ help: change this to: `&[TxExonsRecord]`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
= note: `#[warn(clippy::ptr_arg)]` on by default
Check warning on line 775 in src/data/cdot/json.rs
github-actions / clippy
this call to `as_ref.map(...)` does nothing
warning: this call to `as_ref.map(...)` does nothing
--> src/data/cdot/json.rs:775:22
|
775 | aliases: gene.aliases.as_ref().map(Clone::clone).unwrap_or_default(),
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `gene.aliases.clone()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_asref
Check warning on line 774 in src/data/cdot/json.rs
github-actions / clippy
this call to `as_ref.map(...)` does nothing
warning: this call to `as_ref.map(...)` does nothing
--> src/data/cdot/json.rs:774:22
|
774 | summary: gene.summary.as_ref().map(Clone::clone).unwrap_or_default(),
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `gene.summary.clone()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_asref
Check warning on line 772 in src/data/cdot/json.rs
github-actions / clippy
this call to `as_ref.map(...)` does nothing
warning: this call to `as_ref.map(...)` does nothing
--> src/data/cdot/json.rs:769:20
|
769 | descr: gene
| ____________________^
770 | | .description
771 | | .as_ref()
772 | | .map(Clone::clone)
| |__________________________________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_asref
= note: `#[warn(clippy::useless_asref)]` on by default
help: try
|
769 ~ descr: gene
770 + .description.clone()
|