Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: replacing usages of unwrap() with expect or Result (#70) #73

Merged
merged 1 commit into from
Mar 31, 2023

Conversation

holtgrewe
Copy link
Contributor

The remaining places are OK

$ rg -w unwrap
src/parser/ds.rs
32:    pub fn unwrap(self) -> T {
965:        assert_eq!(Mu::Certain(1).unwrap(), 1);
966:        assert_eq!(Mu::Uncertain(1).unwrap(), 1);

@holtgrewe holtgrewe linked an issue Mar 31, 2023 that may be closed by this pull request
@codecov
Copy link

codecov bot commented Mar 31, 2023

Codecov Report

Patch coverage: 88.34% and project coverage change: -0.08 ⚠️

Comparison is base (a44e28c) 88.31% compared to head (f9c6732) 88.23%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #73      +/-   ##
==========================================
- Coverage   88.31%   88.23%   -0.08%     
==========================================
  Files          19       19              
  Lines        7470     7516      +46     
==========================================
+ Hits         6597     6632      +35     
- Misses        873      884      +11     
Impacted Files Coverage Δ
src/data/uta_sr.rs 53.01% <ø> (ø)
src/normalizer.rs 70.76% <52.38%> (-0.67%) ⬇️
src/mapper/assembly.rs 80.34% <71.42%> (ø)
src/data/uta.rs 91.54% <83.33%> (-0.16%) ⬇️
src/mapper/alignment.rs 91.78% <87.80%> (+0.01%) ⬆️
src/data/cdot/json.rs 93.69% <100.00%> (+0.01%) ⬆️
src/mapper/altseq.rs 95.08% <100.00%> (+0.12%) ⬆️
src/mapper/cigar.rs 96.53% <100.00%> (+0.09%) ⬆️
src/mapper/variant.rs 90.81% <100.00%> (+0.01%) ⬆️
src/parser/impl_parse.rs 99.69% <100.00%> (+<0.01%) ⬆️
... and 3 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@holtgrewe holtgrewe merged commit 94d6f88 into main Mar 31, 2023
@holtgrewe holtgrewe deleted the 70-replace-all-usages-of-unwrap branch March 31, 2023 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace all usages of unwrap
1 participant