chore(deps): update rstest requirement from 0.18 to 0.21 (#171) #124
holtgreweAnnotations
15 warnings
|
release-please
Unexpected input(s) 'package-name', valid inputs are ['token', 'release-type', 'path', 'target-branch', 'config-file', 'manifest-file', 'repo-url', 'github-api-url', 'github-graphql-url', 'fork', 'include-component-in-tag', 'proxy-server', 'skip-github-release', 'skip-github-pull-request', 'changelog-host']
|
|
use of a fallible conversion when an infallible one could be used:
src/parser/ds.rs#L497
warning: use of a fallible conversion when an infallible one could be used
--> src/parser/ds.rs:497:18
|
497 | .try_into()
| ^^^^^^^^ help: use: `into`
|
= note: converting `RnaInterval` to `Range<i32>` cannot fail
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_fallible_conversions
|
|
use of a fallible conversion when an infallible one could be used:
src/parser/ds.rs#L490
warning: use of a fallible conversion when an infallible one could be used
--> src/parser/ds.rs:490:18
|
490 | .try_into()
| ^^^^^^^^ help: use: `into`
|
= note: converting `TxInterval` to `Range<i32>` cannot fail
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_fallible_conversions
= note: `#[warn(clippy::unnecessary_fallible_conversions)]` on by default
|
|
assigning the result of `Clone::clone()` may be inefficient:
src/mapper/altseq.rs#L1007
warning: assigning the result of `Clone::clone()` may be inefficient
--> src/mapper/altseq.rs:1007:17
|
1007 | alternative = insertion.clone();
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use `clone_from()`: `alternative.clone_from(insertion)`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assigning_clones
|
|
assigning the result of `Clone::clone()` may be inefficient:
src/mapper/altseq.rs#L992
warning: assigning the result of `Clone::clone()` may be inefficient
--> src/mapper/altseq.rs:992:17
|
992 | alternative = reference.clone();
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use `clone_from()`: `alternative.clone_from(&reference)`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assigning_clones
|
|
assigning the result of `Clone::clone()` may be inefficient:
src/mapper/altseq.rs#L941
warning: assigning the result of `Clone::clone()` may be inefficient
--> src/mapper/altseq.rs:941:17
|
941 | alternative = insertion.clone();
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use `clone_from()`: `alternative.clone_from(insertion)`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assigning_clones
|
|
assigning the result of `Clone::clone()` may be inefficient:
src/mapper/altseq.rs#L916
warning: assigning the result of `Clone::clone()` may be inefficient
--> src/mapper/altseq.rs:916:13
|
916 | reference = deletion.clone();
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use `clone_from()`: `reference.clone_from(deletion)`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assigning_clones
|
|
assigning the result of `Clone::clone()` may be inefficient:
src/mapper/altseq.rs#L912
warning: assigning the result of `Clone::clone()` may be inefficient
--> src/mapper/altseq.rs:912:13
|
912 | alternative = insertion.clone();
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use `clone_from()`: `alternative.clone_from(insertion)`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assigning_clones
|
|
assigning the result of `ToOwned::to_owned()` may be inefficient:
src/mapper/altseq.rs#L911
warning: assigning the result of `ToOwned::to_owned()` may be inefficient
--> src/mapper/altseq.rs:911:13
|
911 | reference = "".to_owned();
| ^^^^^^^^^^^^^^^^^^^^^^^^^ help: use `clone_into()`: `"".clone_into(&mut reference)`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assigning_clones
|
|
assigning the result of `ToOwned::to_owned()` may be inefficient:
src/mapper/altseq.rs#L880
warning: assigning the result of `ToOwned::to_owned()` may be inefficient
--> src/mapper/altseq.rs:880:13
|
880 | reference = "".to_owned();
| ^^^^^^^^^^^^^^^^^^^^^^^^^ help: use `clone_into()`: `"".clone_into(&mut reference)`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assigning_clones
|
|
assigning the result of `ToOwned::to_owned()` may be inefficient:
src/mapper/altseq.rs#L861
warning: assigning the result of `ToOwned::to_owned()` may be inefficient
--> src/mapper/altseq.rs:861:13
|
861 | reference = "".to_owned();
| ^^^^^^^^^^^^^^^^^^^^^^^^^ help: use `clone_into()`: `"".clone_into(&mut reference)`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assigning_clones
= note: `#[warn(clippy::assigning_clones)]` on by default
|
|
writing `&Vec` instead of `&[_]` involves a new object where a slice will do:
src/mapper/alignment.rs#L60
warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do
--> src/mapper/alignment.rs:60:30
|
60 | pub fn build_tx_cigar(exons: &Vec<TxExonsRecord>, strand: i16) -> Result<CigarString, Error> {
| ^^^^^^^^^^^^^^^^^^^ help: change this to: `&[TxExonsRecord]`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
= note: `#[warn(clippy::ptr_arg)]` on by default
|
|
this call to `as_ref.map(...)` does nothing:
src/data/cdot/json.rs#L775
warning: this call to `as_ref.map(...)` does nothing
--> src/data/cdot/json.rs:775:22
|
775 | aliases: gene.aliases.as_ref().map(Clone::clone).unwrap_or_default(),
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `gene.aliases.clone()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_asref
|
|
this call to `as_ref.map(...)` does nothing:
src/data/cdot/json.rs#L774
warning: this call to `as_ref.map(...)` does nothing
--> src/data/cdot/json.rs:774:22
|
774 | summary: gene.summary.as_ref().map(Clone::clone).unwrap_or_default(),
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `gene.summary.clone()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_asref
|
|
this call to `as_ref.map(...)` does nothing:
src/data/cdot/json.rs#L769
warning: this call to `as_ref.map(...)` does nothing
--> src/data/cdot/json.rs:769:20
|
769 | descr: gene
| ____________________^
770 | | .description
771 | | .as_ref()
772 | | .map(Clone::clone)
| |__________________________________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_asref
= note: `#[warn(clippy::useless_asref)]` on by default
help: try
|
769 ~ descr: gene
770 + .description.clone()
|
|