-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: Update usage_cli.rst #274
Conversation
After fixing submission errors, one needs to re-import the TSV file before re-submission.
WalkthroughThe documentation for the Changes
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Outside diff range and nitpick comments (1)
docs/usage_cli.rst (1)
37-37
: LGTM! Clear and important workflow clarification.The added step clearly explains the necessary process after encountering errors, which was a critical missing piece in the workflow documentation. This aligns well with the PR's objective of improving user guidance.
Consider adding a note about potential waiting time between re-import and re-submit, similar to the existing note about server processing time. For example:
- When there are errors, fix the variants to be submitted, re-import (``clinvar-this`` will create a new payload with ``"record_status": "update"`` for each finding) and then re-submit with ``clinvar-this batch submit``. + When there are errors, fix the variants to be submitted, re-import (``clinvar-this`` will create a new payload with ``"record_status": "update"`` for each finding), and then re-submit with ``clinvar-this batch submit``. Note that you may need to wait briefly after re-import before re-submitting to ensure the payload is properly processed.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
📒 Files selected for processing (1)
- docs/usage_cli.rst (1 hunks)
🧰 Additional context used
🔇 Additional comments (1)
docs/usage_cli.rst (1)
Line range hint
19-21
: Verify workflow diagram update.The PR objectives mention updating the workflow diagram to show the circular path from "fix file content" back to "clinvar-this batch import". Please ensure that the referenced PNG file has been updated accordingly.
Added to documentation:
After fixing submission errors, one needs to re-import the TSV file before re-submission.
Maybe also:
Update PNG displayed on https://clinvar-this.readthedocs.io/en/latest/usage_cli.html to show circling back from
fix file content
toclinvar-this batch import
.Summary by CodeRabbit
clinvar-this
command line tool documentation for enhanced clarity on usage and workflow.