Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: integrate PanelApp for gene-phenotype links (#225) #377

Merged
merged 10 commits into from
Jan 3, 2024

wip

e2f5542
Select commit
Loading
Failed to load commit list.
Sign in for the full log view
Merged

feat: integrate PanelApp for gene-phenotype links (#225) #377

wip
e2f5542
Select commit
Loading
Failed to load commit list.
GitHub Actions / clippy succeeded Jan 3, 2024 in 0s

clippy

7 warnings

Details

Results

Message level Amount
Internal compiler error 0
Error 0
Warning 7
Note 0
Help 0

Versions

  • rustc 1.75.0 (82e1608df 2023-12-21)
  • cargo 1.75.0 (1d8b05cdd 2023-11-20)
  • clippy 0.1.75 (82e1608 2023-12-21)

Annotations

Check warning on line 183 in src/tsv/cli/import/mod.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

the borrowed expression implements the required traits

warning: the borrowed expression implements the required traits
   --> src/tsv/cli/import/mod.rs:183:9
    |
183 |         &format!("{}", args.genome_release),
    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `format!("{}", args.genome_release)`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args

Check warning on line 411 in src/gnomad_nuclear/cli/import.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

the borrowed expression implements the required traits

warning: the borrowed expression implements the required traits
   --> src/gnomad_nuclear/cli/import.rs:411:57
    |
411 |         db.put_cf(&cf_meta, "gnomad-age-distributions", &age_distributions)?;
    |                                                         ^^^^^^^^^^^^^^^^^^ help: change this to: `age_distributions`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args

Check warning on line 408 in src/gnomad_nuclear/cli/import.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

the borrowed expression implements the required traits

warning: the borrowed expression implements the required traits
   --> src/gnomad_nuclear/cli/import.rs:408:53
    |
408 |         db.put_cf(&cf_meta, "gnomad-dbsnp-version", &dbsnp_version)?;
    |                                                     ^^^^^^^^^^^^^^ help: change this to: `dbsnp_version`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args

Check warning on line 405 in src/gnomad_nuclear/cli/import.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

the borrowed expression implements the required traits

warning: the borrowed expression implements the required traits
   --> src/gnomad_nuclear/cli/import.rs:405:51
    |
405 |         db.put_cf(&cf_meta, "gnomad-vep-version", &vep_version)?;
    |                                                   ^^^^^^^^^^^^ help: change this to: `vep_version`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
    = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default

Check warning on line 48 in src/common/noodles.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

accessing first element with `vs.get(0)`

warning: accessing first element with `vs.get(0)`
  --> src/common/noodles.rs:48:12
   |
48 |         Ok(vs.get(0).unwrap().unwrap())
   |            ^^^^^^^^^ help: try: `vs.first()`
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first

Check warning on line 35 in src/common/noodles.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

accessing first element with `vs.get(0)`

warning: accessing first element with `vs.get(0)`
  --> src/common/noodles.rs:35:12
   |
35 |         Ok(vs.get(0).unwrap().unwrap())
   |            ^^^^^^^^^ help: try: `vs.first()`
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first

Check warning on line 14 in src/common/noodles.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

accessing first element with `vs.get(0)`

warning: accessing first element with `vs.get(0)`
  --> src/common/noodles.rs:14:12
   |
14 |         Ok(vs.get(0).unwrap().as_ref().unwrap().to_string())
   |            ^^^^^^^^^ help: try: `vs.first()`
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first
   = note: `#[warn(clippy::get_first)]` on by default