Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: adding support for gnomAD-SV (#291) #297

Merged
merged 1 commit into from
Nov 17, 2023

feat: adding support for gnomAD-SV (#291)

17def5c
Select commit
Loading
Failed to load commit list.
Sign in for the full log view
Merged

feat: adding support for gnomAD-SV (#291) #297

feat: adding support for gnomAD-SV (#291)
17def5c
Select commit
Loading
Failed to load commit list.
GitHub Actions / clippy succeeded Nov 17, 2023 in 1s

clippy

5 warnings

Details

Results

Message level Amount
Internal compiler error 0
Error 0
Warning 5
Note 0
Help 0

Versions

  • rustc 1.74.0 (79e9716c9 2023-11-13)
  • cargo 1.74.0 (ecb9851af 2023-10-18)
  • clippy 0.1.74 (79e9716 2023-11-13)

Annotations

Check warning on line 183 in src/tsv/cli/import/mod.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

the borrowed expression implements the required traits 

warning: the borrowed expression implements the required traits
   --> src/tsv/cli/import/mod.rs:183:9
    |
183 |         &format!("{}", args.genome_release),
    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `format!("{}", args.genome_release)`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args

Check warning on line 368 in src/gnomad_sv/cli/import/gnomad_sv4.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

this expression creates a reference which is immediately dereferenced by the compiler 

warning: this expression creates a reference which is immediately dereferenced by the compiler
   --> src/gnomad_sv/cli/import/gnomad_sv4.rs:368:40
    |
368 |         .map(|path_in_tsv| import_file(&db, cf_data_name, path_in_tsv))
    |                                        ^^^ help: change this to: `db`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
    = note: `#[warn(clippy::needless_borrow)]` on by default

Check warning on line 346 in src/gnomad_nuclear/cli/import.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

the borrowed expression implements the required traits 

warning: the borrowed expression implements the required traits
   --> src/gnomad_nuclear/cli/import.rs:346:57
    |
346 |         db.put_cf(&cf_meta, "gnomad-age-distributions", &age_distributions)?;
    |                                                         ^^^^^^^^^^^^^^^^^^ help: change this to: `age_distributions`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args

Check warning on line 343 in src/gnomad_nuclear/cli/import.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

the borrowed expression implements the required traits 

warning: the borrowed expression implements the required traits
   --> src/gnomad_nuclear/cli/import.rs:343:53
    |
343 |         db.put_cf(&cf_meta, "gnomad-dbsnp-version", &dbsnp_version)?;
    |                                                     ^^^^^^^^^^^^^^ help: change this to: `dbsnp_version`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args

Check warning on line 340 in src/gnomad_nuclear/cli/import.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

the borrowed expression implements the required traits 

warning: the borrowed expression implements the required traits
   --> src/gnomad_nuclear/cli/import.rs:340:51
    |
340 |         db.put_cf(&cf_meta, "gnomad-vep-version", &vep_version)?;
    |                                                   ^^^^^^^^^^^^ help: change this to: `vep_version`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
    = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default
View more details on GitHub Actions