feat: provide proto3 JSON serialization for prost structs (#301) #415
holtgreweconventional-prs.yml
on: pull_request_target
title-format
2s
Annotations
6 warnings
|
title-format
The following actions uses node12 which is deprecated and will be forced to run on node16: amannn/[email protected]. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
|
|
the borrowed expression implements the required traits:
src/tsv/cli/import/mod.rs#L183
warning: the borrowed expression implements the required traits
--> src/tsv/cli/import/mod.rs:183:9
|
183 | &format!("{}", args.genome_release),
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `format!("{}", args.genome_release)`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
|
|
the borrowed expression implements the required traits:
src/gnomad_nuclear/cli/import.rs#L346
warning: the borrowed expression implements the required traits
--> src/gnomad_nuclear/cli/import.rs:346:57
|
346 | db.put_cf(&cf_meta, "gnomad-age-distributions", &age_distributions)?;
| ^^^^^^^^^^^^^^^^^^ help: change this to: `age_distributions`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
|
|
the borrowed expression implements the required traits:
src/gnomad_nuclear/cli/import.rs#L343
warning: the borrowed expression implements the required traits
--> src/gnomad_nuclear/cli/import.rs:343:53
|
343 | db.put_cf(&cf_meta, "gnomad-dbsnp-version", &dbsnp_version)?;
| ^^^^^^^^^^^^^^ help: change this to: `dbsnp_version`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
|
|
the borrowed expression implements the required traits:
src/gnomad_nuclear/cli/import.rs#L340
warning: the borrowed expression implements the required traits
--> src/gnomad_nuclear/cli/import.rs:340:51
|
340 | db.put_cf(&cf_meta, "gnomad-vep-version", &vep_version)?;
| ^^^^^^^^^^^^ help: change this to: `vep_version`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
= note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default
|
|
an implementation of `From` is preferred since it gives you `Into<_>` for free where the reverse isn't true:
src/cons/cli/import.rs#L34
warning: an implementation of `From` is preferred since it gives you `Into<_>` for free where the reverse isn't true
--> src/cons/cli/import.rs:34:5
|
34 | impl Into<crate::pbs::cons::Record> for Record {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#from_over_into
= note: `#[warn(clippy::from_over_into)]` on by default
help: replace the `Into` implementation with `From<cons::cli::import::reading::Record>`
|
34 ~ impl From<Record> for crate::pbs::cons::Record {
35 ~ fn from(val: Record) -> Self {
36 | crate::pbs::cons::Record {
37 ~ chrom: val.chromosome,
38 ~ start: val.start,
39 ~ stop: val.start,
40 ~ hgnc_id: val.hgnc_id,
41 ~ enst_id: val.enst_id,
42 ~ exon_num: val.exon_num,
43 ~ exon_count: val.exon_count,
44 ~ alignment: val.alignment,
|
|