Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

api4: std.SetFrameProp no longer supports deleting frame property #736

Closed
AkarinVS opened this issue Aug 23, 2021 · 3 comments
Closed

api4: std.SetFrameProp no longer supports deleting frame property #736

AkarinVS opened this issue Aug 23, 2021 · 3 comments

Comments

@AkarinVS
Copy link
Contributor

I understand that api4 have introduced std.RemoveFrameProps dedicated for this purpose, but I think removing delete support from std.SetFrameProp breaks backword compatibility for no good reason and makes writing portable scripts that work with both api3 and api4 VS unnecessarily harder than it should be.

What's the rationale behind this backward incompatible change?

Thanks.

@myrsloik
Copy link
Member

Mostly that having a function that both sets and deletes gets a really convoluted argument list and isn't intuitive at all.

@AkarinVS
Copy link
Contributor Author

AkarinVS commented Aug 23, 2021 via email

@AkarinVS
Copy link
Contributor Author

AkarinVS commented Aug 26, 2021 via email

AkarinVS added a commit to AkarinVS/vapoursynth that referenced this issue Sep 2, 2021
and suggest users to look into SetFrameProps and RemoveFrameProps APIs.

Fixes vapoursynth#736.

Signed-off-by: akarin <[email protected]>
AkarinVS added a commit to AmusementClub/vapoursynth-classic that referenced this issue Sep 3, 2021
and suggest users to look into SetFrameProps and RemoveFrameProps APIs.

Fixes vapoursynth#736.

Signed-off-by: akarin <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants