Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix mishandling of URL #257

Merged
merged 9 commits into from
Jan 31, 2024
Merged

Fix mishandling of URL #257

merged 9 commits into from
Jan 31, 2024

Conversation

gwynne
Copy link
Member

@gwynne gwynne commented Jan 28, 2024

These changes are now available in 2.12.3

We have for some time now been incorrectly encoding URLs in an incorrect format that fails to trivially round-trip back through decoding. This is now fixed. Any previously broken data stored in a database affected by this issue will now be correctly read back and will have the correct format when next written.

Note

This is not related in any way to the recent issues with Vapor's URI type; it is a separate concern affecting the URL type that comes from Foundation.

Also incidentally fixes #255

@gwynne gwynne added bug Something isn't working semver-patch Internal changes only labels Jan 28, 2024
@codecov-commenter
Copy link

codecov-commenter commented Jan 28, 2024

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (81d1106) 36.27% compared to head (ccba064) 37.86%.
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #257      +/-   ##
==========================================
+ Coverage   36.27%   37.86%   +1.58%     
==========================================
  Files          13       13              
  Lines         736      750      +14     
==========================================
+ Hits          267      284      +17     
+ Misses        469      466       -3     
Files Coverage Δ
Sources/PostgresKit/ConnectionPool+Postgres.swift 35.71% <ø> (ø)
Sources/PostgresKit/PostgresDataTranslation.swift 67.28% <100.00%> (+3.73%) ⬆️
Sources/PostgresKit/PostgresDatabase+SQL.swift 85.29% <100.00%> (ø)
Sources/PostgresKit/SQLPostgresConfiguration.swift 85.10% <100.00%> (ø)
...stgresConnectionSource+PostgresConfiguration.swift 0.00% <0.00%> (ø)
...PostgresKit/Deprecations/PostgresDataEncoder.swift 0.00% <0.00%> (ø)

.github/dependabot.yml Outdated Show resolved Hide resolved
.github/dependabot.yml Outdated Show resolved Hide resolved
[email protected] Show resolved Hide resolved
Tests/PostgresKitTests/PostgresKitTests.swift Show resolved Hide resolved
@gwynne gwynne requested a review from MahdiBM January 30, 2024 17:37
@gwynne gwynne enabled auto-merge (squash) January 31, 2024 08:22
@gwynne gwynne merged commit 475bf6f into main Jan 31, 2024
22 checks passed
@gwynne gwynne deleted the fix-handling-of-url branch January 31, 2024 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working semver-patch Internal changes only
Projects
None yet
Development

Successfully merging this pull request may close these issues.

URL is not supported as a postgres codable type
3 participants