Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix not-regexp operator, add case insensitive regexp operators #139

Merged
merged 1 commit into from
Mar 31, 2020
Merged

Fix not-regexp operator, add case insensitive regexp operators #139

merged 1 commit into from
Mar 31, 2020

Conversation

ffried
Copy link
Contributor

@ffried ffried commented Aug 6, 2019 •
edited by tanner0101
Loading

Fixes the notRegexp operator and adds the two case-insensitive variants (#139, #90).

See the pgsql docs for reference.

@ffried
Copy link
Contributor Author

ffried commented Mar 31, 2020

@tanner0101 Ping... 🙂

@tanner0101 tanner0101 added enhancement New feature or request semver-minor Contains new APIs labels Mar 31, 2020
tanner0101
tanner0101 approved these changes Mar 31, 2020
View reviewed changes
Copy link
Member

@tanner0101 tanner0101 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry I missed this, thanks for the ping.

@tanner0101 tanner0101 merged commit 489537a into vapor:1 Mar 31, 2020
@ffried ffried deleted the bugfix/not_regexp branch March 31, 2020 16:41
@ffried
Copy link
Contributor Author

ffried commented Mar 31, 2020

No worries. Thanks for merging!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tanner0101 tanner0101 tanner0101 approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request semver-minor Contains new APIs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ffried @tanner0101