Revised error handling in Encodable conformance for Fields #538
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… recovery strategy used by the fixes in the database driver layers works. Includes test for the issue which triggered said fixes.
0xTim
approved these changes
Oct 27, 2022
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #538 +/- ##
=======================================
Coverage 45.72% 45.72%
=======================================
Files 101 101
Lines 5737 5737
=======================================
Hits 2623 2623
Misses 3114 3114
Flags with carried forward coverage won't be shown. Click here to find out more.
|
|
These changes are now available in 1.35.2 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows the fixes in vapor/postgres-kit#234 and vapor/mysql-kit#313 to work correctly and adds testing of the affected functionality.