Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix frontend ingress issue when no hosts are provided. #381

Merged
merged 2 commits into from
Oct 6, 2020

Conversation

willgraf
Copy link
Contributor

@willgraf willgraf commented Oct 6, 2020

There should be a default rule for HTTP traffic if there are no hosts available.

Default hosts values have also been updated to empty lists as opposed to example.com.

@willgraf willgraf merged commit c44e656 into stable Oct 6, 2020
@willgraf willgraf deleted the bugfix/ingress branch October 6, 2020 16:24
willgraf added a commit that referenced this pull request Dec 16, 2020
* Support TLS traffic with cert-manager. (#357)

* Fix frontend ingress issue when no hosts are provided. (#381)

* Template frontend ingress annotations using `CERTIFICATE_MANAGER_ENABLED` (#383)

* Create tf-serving configuration files using an initContainer. (#382)

* Fix whitespace issue in tasks/Makefile.kubectl (#386)

* Bump openvpn to 4.2.3 (#385)

* Upgrade certificate manager to version 1.0.3 (#384)

* Add screenshot of successfully created cluster to docs. (#388)

* Set up an AlertManager with slack receiver support (#317)

* Install procps to give access to sysctl. (#390)

* Migrate CI/CD from TravisCI to GitHub Actions (#394)

* Change the redis helm chart repo to bitnami (#393)

* Upgrade tf-serving chart to 0.3.0 for application version 0.4.0 (#392)

* Move the frontend HPA definition into the helm chart. (#395)

* Move the tf-serving HPA into the helm chart. (#396)

* Move redis-consumer HPA into the helm chart. (#397)

* Remove deprecated and unused charts (#398)

* Migrate stable helm chart repo to archived URL. (#399)

* Destroy the secret and remove the key from the DNS solver SA in a new task: `gke/destroy/certificate-manager-secret` (fixes #391).

* Use GCP_SERVICE_ACCOUNT for DNS resolution (#401)

* Clean up docs and test them with new GitHub Action workflow (#402)

* Add code-formatted filename to list of files to change (#403)

* Update ELK stack helmfiles (#380)

* Move the prometheus-redis-exporter script to a chart using incubator/raw. (#405)

* Use `kubectl del pvc` instead of deleting all pds with the cluster name. (#406)

* Update helmfile defaults for faster helm deployments. (#404)

* Skip gke/destroy/node-pools during cluster teardown. (#407)

* Update docs to reflect the pending 1.4.0 release. (#408)

* Bump redis-consumer version to 0.8.3 (#409)

* Run integration tests on all PRs to master OR if they have the commit message. (#411)

* Remove helm defaults for ELK helmfiles (#413)

Co-authored-by: Morgan Schwartz <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant