Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge #2

Merged
merged 37 commits into from
Jan 15, 2021
Merged

Merge #2

merged 37 commits into from
Jan 15, 2021

Conversation

vanlooverenkoen
Copy link
Owner

Description

Replace this paragraph with a description of what this PR is doing. If you're modifying existing behavior, describe the existing behavior, how this PR is changing it, and what motivated the change.

Related Issues

Replace this paragraph with a list of issues related to this PR from the issue database. Indicate, which of these issues are resolved or fixed by this PR. Note that you'll have to prefix the issue numbers with flutter/flutter#.

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (flutter analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy.
  • I updated CHANGELOG.md to add a description of the change.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change (please indicate a breaking change in CHANGELOG.md and increment major revision).
  • No, this is not a breaking change.

BeMacized and others added 30 commits December 27, 2020 16:02
@BeMacized @mvanbeusekom
[camera] Fix video recording exception on Android (#3375)
7eff062 
* Fixed video recording

* Update changelog and pubspec version

* Update packages/camera/camera/CHANGELOG.md

Co-authored-by: Maurits van Beusekom <[email protected]>

Co-authored-by: Maurits van Beusekom <[email protected]>
@danielroek @mvanbeusekom
[camera] Added maxVideoDuration to startVideoRecording (#3365)
3ec0d64 
* Added maxVideoDuration to startVideoRecording

* updated documentation

Co-authored-by: Maurits van Beusekom <[email protected]>

* updated documentation

Co-authored-by: Maurits van Beusekom <[email protected]>

* Fixed long line in docs

* Formatting

Co-authored-by: Maurits van Beusekom <[email protected]>
@BeMacized
[camera_platform_interface] Add platform interface methods for settin…
1c00905 
…g auto exposure. (#3345)

* Added platform interface methods for setting auto exposure.

* Added platform interface methods for setting auto exposure.

* Remove workspace files
@mvanbeusekom
Update camera_platform_interface to 1.2.0 (#3376)
65d041f
@BeMacized
Change platform interface dependency (#3377)
72cc8e2
@BeMacized
[camera] Add iOS and Android implementations for managing auto exposu…
96e2328 
…re. (#3346)

* Added platform interface methods for setting auto exposure.

* Added platform interface methods for setting auto exposure.

* Remove workspace files

* Added auto exposure implementations for Android and iOS

* iOS fix for setting the exposure point

* Removed unnecessary check

* Update platform interface dependency

* Implement PR feedback

* Restore test

* Small improvements for exposure point resetting
@anniek-valk @mvanbeusekom
Added closeCaptureSession() to stopVideoRecording in Camera.java to f…
cfa7098 
…ix an Android 6 crash (#3336)

Co-authored-by: Maurits van Beusekom <[email protected]>
@danielroek @mvanbeusekom
[camera_platform_interface] Added imageFormatGroup to initialize (#3364)
16f37e9 
* Added imageFormatGroup to initialize

* Apply suggestions from code review

Co-authored-by: Maurits van Beusekom <[email protected]>

* Added period to sentence

* Moved ImageFormatGroup to platform_interface; Added extension to convert ImageFormatGroup to name; Changed int to ImageFormatGroup for initializeCamera

* Fixed test

* Separated Android and iOS in name extension

* Clarified returns on name extension

* Export image_format_group.dart in types.dart

* Changed enum values to lowercase

* Added ImageFormatGroup test

* Fixed formatting

* Removed target platform switch.

* Fixed formatting

Co-authored-by: Maurits van Beusekom <[email protected]>
@danielroek
[camera] Fixed stale images in imageStream subscriptions (#3344)
0394183 
* Fixed stale images in imageStream subscriptions

* Implemented feedback

* Fixed format exception

* added null-check for imageStreamReader

* Removed setOnImageAvailableListener from onCancel

* fixed formatting
@mvanbeusekom
[camera] disable auto focus when using front facing camera on Android (…
b64bebf 
…#3383)

* Refactured Camera and fix issue front facing camera

* Update FPS range on Android to have correct brightness

* Formatted files

* Fix version conflict
@BeMacized @mvanbeusekom
[camera_platform_interface] Add platform interface methods for settin…
dac4b6f 
…g auto focus. (#3369)

* Added platform interface methods for setting auto exposure.

* Added platform interface methods for setting auto exposure.

* Remove workspace files

* Added auto exposure implementations for Android and iOS

* Added platform interface methods for managing auto focus.

* Formatted code

* Export focus mode

* Update platform interface for changes to autofocus methods

* Revert "Update platform interface for changes to autofocus methods"

This reverts commit bdeed1d.

* iOS fix for setting the exposure point

* Removed unnecessary check

* Updated changelog and pubspec.yaml

* Update platform interface dependency

* Implement PR feedback

* Restore test

* Revert test change

* Update camera pubspec

* Update platform interface to prevent breaking changes with current master

Co-authored-by: Maurits van Beusekom <[email protected]>
@BeMacized @mvanbeusekom
[camera_platform_interface] Add platform interface methods for lockin…
43ee609 
…g capture orientation. (#3389)

* Expand platform interface to support reporting device orientation

* Switch to flutter DeviceOrientation enum

* Add interface methods for (un)locking the capture orientation.

* Update capture orientation interfaces and add unit tests.

* Made device orientation mandatory for locking capture orientation in the platform interface.

* Update comment

* Update comment.

* Update changelog and pubspec version

* Update packages/camera/camera_platform_interface/lib/src/events/device_event.dart

Co-authored-by: Maurits van Beusekom <[email protected]>

* Update packages/camera/camera_platform_interface/lib/src/events/device_event.dart

Co-authored-by: Maurits van Beusekom <[email protected]>

* Update packages/camera/camera_platform_interface/lib/src/events/device_event.dart

Co-authored-by: Maurits van Beusekom <[email protected]>

* Update packages/camera/camera_platform_interface/lib/src/events/device_event.dart

Co-authored-by: Maurits van Beusekom <[email protected]>

* Update packages/camera/camera_platform_interface/lib/src/method_channel/method_channel_camera.dart

Co-authored-by: Maurits van Beusekom <[email protected]>

* Update packages/camera/camera_platform_interface/lib/src/method_channel/method_channel_camera.dart

Co-authored-by: Maurits van Beusekom <[email protected]>

Co-authored-by: Maurits van Beusekom <[email protected]>
Co-authored-by: Maurits van Beusekom <[email protected]>
@markfili
[camera] set useAutoFocus to true by default (#3396)
d026d07 
* set useAutoFocus to true by default

there's no way to set useAutoFocus to `true` and it is `false` by default so the auto focus is not working.

* Update pubspec.yaml

* Update CHANGELOG.md
@amanv8060
[image_picker] Update README.md (#3098)
d0fd4b1
@impure
[in_app_purchase] Added serviceTimeout code (#3287)
1b7afc5
@HansMuller
Update obsolete button refs in plugin examples (#3395)
a7dd769
fix version (#3399)
105c2bc
@zanderso
Ignore deprecated_member_use analysis lint (#3400)
d01c84c
@bparrishMines
[battery] Migrate battery_plugin_interface to null safety (#3366)
b3bc1f2
@Hixie
Sync the PR template to the new style (#3397)
34faaaf
@danielroek @anniek-valk @mvanbeusekom
[camera] Implemented ImageStream ImageFormat setting for Dart and And…
da1b463 
…roid (#3359)

* Implemented ImageStream ImageFormat setting for Dart and Android

* Fixed formatting and toString test

* Apply suggestions from code review

* Removed imageStreamImageFormat from CameraValue

* Removed imageStreamImageFormat from CameraValue

* Removed imageStreamImageFormat from CameraValue

* fixed formatting

* fixed formatting

* fixed formatting

* WIP: iOS implementation

* Imaplemented suggested changes, added tests.

* iOS switch case videoFormat

* Added imageFormatGroup to initialize

* Apply suggestions from code review

Co-authored-by: Maurits van Beusekom <[email protected]>

* Added period to sentence

* Moved ImageFormatGroup to platform_interface; Added extension to convert ImageFormatGroup to name; Changed int to ImageFormatGroup for initializeCamera

* Fixed test

* Separated Android and iOS in name extension

* Clarified returns on name extension

* updated Android implementation to support String output

* removed getOrDefault

* Updated camera implementation to use ImageFormatGroupName; Updated to Dart 2.7.0 to support extensions;

* removed unused import

* Export image_format_group.dart in types.dart

* Changed enum values to lowercase

* Added ImageFormatGroup test

* Fixed formatting

* made enum strings lowercase

* Removed target platform switch.

* Fixed formatting

* Updated Android implementation

* Updated iOS implementation

* updated log message for unsupported ImageFormatGroup

* Updated Android implementation

* fixed period in docs

* Switch change to if-statement

* Moved switching videoFormat to method in iOS

* Implemented feedback

* fixed formatting

* fixed mistakingly removed bracket

* fixed formatting

* Updated version

* Updated version

* fixed formatting

* Define TAG correctly

Co-authored-by: anniek <[email protected]>
Co-authored-by: Maurits van Beusekom <[email protected]>
Co-authored-by: Maurits van Beusekom <[email protected]>
@BeMacized @mvanbeusekom
[camera] Add iOS and Android implementations for managing auto focus. (…
71a8317 
…#3370)

* Added platform interface methods for setting auto exposure.

* Added platform interface methods for setting auto exposure.

* Remove workspace files

* Added auto exposure implementations for Android and iOS

* Added platform interface methods for managing auto focus.

* Formatted code

* Export focus mode

* Add Android and iOS implementations (WIP)

* Update platform interface for changes to autofocus methods

* WIP

* Revert "Update platform interface for changes to autofocus methods"

This reverts commit bdeed1d.

* Finish android implementation

* Fix iOS implementation

* iOS fix for setting the exposure point

* Removed unnecessary check

* Updated changelog and pubspec.yaml

* Updated changelog and pubspec.yaml

* Update platform interface dependency

* Implement PR feedback

* Restore test

* Revert test change

* Update camera pubspec

* Update platform interface to prevent breaking changes with current master

* Update test to match platform interface updates

* Code format

* Fixed compilation error

* Fix formatting

* Add missing license headers to java source files.

* Update platform interface dependency

* Change fps range determination

* Fix analysis warnings

Co-authored-by: Maurits van Beusekom <[email protected]>
@sanekyy
[google_maps_flutter_platform_interface] Adds support for holes in po…
a0e7937 
…lygon overlays to the Google Maps plugin (#3135)
@Piinks
[video_player] Migrate deprecated api (#3409)
782a7a9
@bparrishMines
[battery] Migrate battery to null safety (#3380)
4fec227
@tugorez
[file_selector_web] Add initial implementation (#3141)
1eabad7 
Add the file_selector web implementation
@BeMacized
[camera] Implemented capture orientation locking. Fixed preview rotat…
100c747 
…ion issues. Fixed video and photo orientation upon save. (#3390)
@sanekyy
[google_maps_flutter] Adds support for holes in polygon overlays to t…
0434f06 
…he Google Maps plugin (#1721)
@ditman
[file_selector_web] Add dummy ios directory. (#3416)
edda73d 
This is required so the plugin is publishable.
@BeMacized
[camera] Fix picture capture causing a crash on some Huawei devices. (#…
6d18db8 
…3414)
BeMacized and others added 7 commits January 14, 2021 10:33
@BeMacized @mvanbeusekom
[camera] Fix initialization error in camera example on iOS (#3406)
d0b7109 
* Fix error on first camera initialize in example app

* Improved error handling a bit & updated tests.

* Updated pubspec and changelog

Co-authored-by: Maurits van Beusekom <[email protected]>
@najeira
[camera] Fixes crash with using inner camera on some Android devices. (…
980b674 
…#3419)
@mvanbeusekom
[camera] Copy zoom settings from preview to final capture builder on …
5916f55 
…Android (#3413)

* Copy SCALER_CROP_REGION from preview to final capture builder

* Update version number

* Fix formatting
@klaes-ashford
fix to properly place polyline at initial camera position in example …
1e90b58 
…app (#2941)
@mvanbeusekom
[camera] Fixes crash when taking a picture on iOS devices without fla…
8313444 
…sh (#3411)
@tugorez
[file_selector_platform_interface] Bump the cross_file version (#3422)
cc234f6
@kennethj
[local_auth] Allow device authentication (pin/pattern/passcode) (#2489)
eccc3cd
@vanlooverenkoen vanlooverenkoen merged commit a23c003 into vanlooverenkoen:master Jan 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.