Fix conditional style ordering #893
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 3d09c6b The changes in this PR will be included in the next version bump. This PR includes changesets to release 8 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
…s/vanilla-extract into fix-condition-sorting
askoufis
approved these changes
Nov 16, 2022
| const matchingCondition = this.ruleset.find( | ||
| (cond) => cond.query === query, | ||
| ); | ||
| for (const { query, rules, children } of incomingRuleset.ruleset.values()) { |
There was a problem hiding this comment.
The comment on the line above should now be Wait nevermind it's still constructing an array.Merge rulesets into one map, or you could shorten it to Merge rulesets to make it data structure agnostic.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves an issue where our conditional style sort algorithm was not implementing the
Array.sortspec correctly. It didn't handle conditions that don't have direct relationships to each other.I have refactored
conditionalRulesetsto instead store rulesets as aMap(which is ideal for lookups) and then return a correctly sorted ruleset array when requested.Fixes #874