Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use async Babel transform in integration/transform.ts #869

Merged
merged 3 commits into from
Oct 6, 2022

Conversation

mrm007
Copy link
Contributor

@mrm007 mrm007 commented Oct 5, 2022

Currently both transforms are synchronous because the Babel transform method used is just an alias for transformSync — see here and here.

Copy link
Contributor

@mattcompiles mattcompiles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will need a changeset. LGTM otherwise

Co-authored-by: mattcompiles <[email protected]>
@changeset-bot
Copy link

changeset-bot bot commented Oct 6, 2022

🦋 Changeset detected

Latest commit: 9dd0a7b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@vanilla-extract/integration Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@mattcompiles mattcompiles enabled auto-merge (squash) October 6, 2022 03:16
@mattcompiles mattcompiles merged commit 2d08761 into master Oct 6, 2022
@mattcompiles mattcompiles deleted the use-async-babel-transform branch October 6, 2022 03:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants