Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix entrypoint resolving in Vitest #833

Merged
merged 1 commit into from
Sep 19, 2022
Merged

Fix entrypoint resolving in Vitest #833

merged 1 commit into from
Sep 19, 2022

Conversation

mattcompiles
Copy link
Contributor

@mattcompiles mattcompiles commented Sep 19, 2022

This PR gets .css.ts files working in the Vitest test runner. WIthout the exports definitions, Vitest was (stragely) resolving the ESM version of @vanilla-extract/css but the CJS version of @vanilla-extract/css/fileScope, causing filescope errors.

@mattcompiles mattcompiles requested a review from a team September 19, 2022 05:43
@changeset-bot
Copy link

changeset-bot bot commented Sep 19, 2022

🦋 Changeset detected

Latest commit: 6413db7

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 8 packages
Name Type
@vanilla-extract/css Patch
@fixtures/features Patch
@fixtures/low-level Patch
@fixtures/recipes Patch
@fixtures/sprinkles Patch
@fixtures/themed Patch
@fixtures/unused-modules Patch
vanilla-extract-example-webpack-react Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@mattcompiles mattcompiles enabled auto-merge (squash) September 19, 2022 05:44
@mattcompiles mattcompiles merged commit b53558a into master Sep 19, 2022
@mattcompiles mattcompiles deleted the vitest-fix branch September 19, 2022 05:46
@seek-oss-ci seek-oss-ci mentioned this pull request Sep 19, 2022
@AndrewLeedham AndrewLeedham mentioned this pull request Dec 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants