Fix Rollup/Vite generated exports #801
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: ae10b85 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
mrm007
commented
Aug 30, 2022
mrm007
commented
Aug 30, 2022
…veloper.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Symbol/toStringTag Vite/Rollup sets this property to 'Module' which confuses _.isPlainObject - https://rollupjs.org/guide/en/#outputgeneratedcode (output.generatedCode.symbols) - vitejs/vite#5018 - https://github.com/vitejs/vite/blob/757a92f1c7c4fa961ed963edd245df77382dfde6/packages/vite/src/node/build.ts#L466-L469
| value, | ||
| /(features_compositionOnly__1o6ek504|features_styleCompositionInSelector__1o6ek507|features_styleVariantsCompositionInSelector_variant__1o6ek50a)\s/g, | ||
| ); | ||
| const exportsObject = evalCode(`module.exports = ${exports}`, 'dummy.js'); |
There was a problem hiding this comment.
Why are we using eval here? Looks like we could just snapshot exports to the same effect?
There was a problem hiding this comment.
Yes, of course. I wanted to make it easier to read than
expect(exports).toMatchInlineSnapshot(
`"{compositionOnly:'features_mergedStyle__1o6ek500 features_styleWithComposition__1o6ek501',mergedStyle:'features_mergedStyle__1o6ek500',styleCompositionInSelector:'features__1o6ek505 features__1o6ek506',styleVariantsCompositionInSelector:{variant:'features__1o6ek508 features__1o6ek509'},styleVariantsWithComposition:{variant:'features_styleVariantsWithComposition_variant__1o6ek502 features_mergedStyle__1o6ek500'},styleVariantsWithMappedComposition:{variant:'features_styleVariantsWithMappedComposition_variant__1o6ek503 features_mergedStyle__1o6ek500'},styleWithComposition:'features_styleWithComposition__1o6ek501 features_mergedStyle__1o6ek500'}"`,
);There was a problem hiding this comment.
Could we use JSON.parse instead?
There was a problem hiding this comment.
Nope, not a JSON string (keys are not quoted and values are quoted with single quotes)
mattcompiles
approved these changes
Sep 1, 2022
Co-authored-by: mattcompiles <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
generatedCode: 'es2015'for rollup build vitejs/vite#5018