fix: change the order of function overloading(createTheme)

[pengooseDev]

PR Context

Fixes #1267

It seems to be a pretty valid way to deduce the parameters of the token by reordering the overloading of the function. However, the sideEffect(tradeOff) for the case where tokens are used as the first parameter should also be considered.
Based on the frequency of use of function signatures, I think the current changes can provide a better DX. :)
I'd appreciate it if you could give me some feedback on what you think about this.

// It seems be better to sort the function signatures by the frequency of user use. 🎯
export function createTheme<ThemeContract extends Contract>( 
  themeContract: ThemeContract,
  tokens: MapLeafNodes<ThemeContract, string>,
  debugId?: string,
): string;
export function createTheme<ThemeTokens extends Tokens>(
  tokens: ThemeTokens,
  debugId?: string,
): [className: string, vars: ThemeVars<ThemeTokens>];
export function createTheme(arg1: any, arg2?: any, arg3?: string): any {
  const themeClassName = generateIdentifier(
    typeof arg2 === 'object' ? arg3 : arg2,
  );

  registerClassName(themeClassName, getFileScope());

  const vars =
    typeof arg2 === 'object'
      ? createGlobalTheme(themeClassName, arg1, arg2)
      : createGlobalTheme(themeClassName, arg1);

  return vars ? [themeClassName, vars] : themeClassName;
}

---

Fixed

[changeset-bot]

🦋 Changeset detected

Latest commit: 99ba624

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 27 packages

Name	Type
@vanilla-extract/css	Patch
@vanilla-extract/integration	Patch
@vanilla-extract/rollup-plugin	Patch
@fixtures/features	Patch
@fixtures/layers	Patch
@fixtures/low-level	Patch
@fixtures/next-app-router	Patch
@fixtures/next-pages-router	Patch
@fixtures/recipes	Patch
@fixtures/sprinkles	Patch
@fixtures/template-string-paths	Patch
@fixtures/themed	Patch
@fixtures/thirdparty	Patch
@fixtures/unused-modules	Patch
@fixtures/thirdparty-dep	Patch
@fixtures/thirdparty-dep-dep	Patch
vanilla-extract-example-remix	Patch
vanilla-extract-example-webpack-react	Patch
@vanilla-extract-private/tests	Patch
@vanilla-extract/esbuild-plugin-next	Patch
@vanilla-extract/esbuild-plugin	Patch
@vanilla-extract/jest-transform	Patch
@vanilla-extract/parcel-transformer	Patch
@vanilla-extract/vite-plugin	Patch
@vanilla-extract/webpack-plugin	Patch
@vanilla-extract-private/test-helpers	Patch
@vanilla-extract/next-plugin	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[askoufis]

Thanks for the PR. I don't really think frequency of use plays into this. It's really just exploiting the behaviour of function overloads to fix the big. It's not perfect, but I don't really think there's a better way to fix it.