Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

css, integration: Replace outdent dependency with dedent #1386

Merged
merged 3 commits into from
Apr 29, 2024

Conversation

askoufis
Copy link
Contributor

@askoufis askoufis commented Apr 20, 2024

Really the only reason to move is that dedent seems much more actively maintained than outdent.

Copy link

changeset-bot bot commented Apr 20, 2024

🦋 Changeset detected

Latest commit: 456545b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 19 packages
Name Type
@vanilla-extract/integration Patch
@vanilla-extract/css Patch
@vanilla-extract-private/tests Patch
@fixtures/features Patch
@fixtures/layers Patch
@fixtures/low-level Patch
@fixtures/next-app-router Patch
@fixtures/next-pages-router Patch
@fixtures/recipes Patch
@fixtures/sprinkles Patch
@fixtures/template-string-paths Patch
@fixtures/themed Patch
@fixtures/thirdparty Patch
@fixtures/unused-modules Patch
@fixtures/thirdparty-dep Patch
@fixtures/thirdparty-dep-dep Patch
vanilla-extract-example-remix Patch
vanilla-extract-example-webpack-react Patch
@vanilla-extract-private/test-helpers Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@askoufis askoufis changed the title Replace outdent dependency with dedent css, integration: Replace outdent dependency with dedent Apr 20, 2024
@askoufis askoufis enabled auto-merge (squash) April 29, 2024 12:52
@askoufis askoufis merged commit e58cf90 into master Apr 29, 2024
11 checks passed
@askoufis askoufis deleted the replace-outdent branch April 29, 2024 12:56
@SimenB
Copy link
Contributor

SimenB commented May 2, 2024

I think this change broke something in how dedenting works when passing a multiline string in @vanilla-extract/css.

import { createGlobalTheme } from "@vanilla-extract/css";

const vars = createGlobalTheme(":root", {
  focusWithin: {
    highlightBoxShadow: `
      0px 0px 0px 4px #DEEFFF
    `,
  },
});

This works fine in 1.15.0, but with 1.15.1 the backticks are turned into ", which is a syntax error.

It might not be the change in this PR, but it who knows 🙂 It broke in the patch release this PR was included in at least

@askoufis
Copy link
Contributor Author

askoufis commented May 3, 2024

I think this change broke something in how dedenting works when passing a multiline string in @vanilla-extract/css.

import { createGlobalTheme } from "@vanilla-extract/css";

const vars = createGlobalTheme(":root", {
  focusWithin: {
    highlightBoxShadow: `
      0px 0px 0px 4px #DEEFFF
    `,
  },
});

This works fine in 1.15.0, but with 1.15.1 the backticks are turned into ", which is a syntax error.

It might not be the change in this PR, but it who knows 🙂 It broke in the patch release this PR was included in at least

I can't seem to reproduce this. This is the CSS that I'm seeing generated. It looks a bit weird, but is otherwise completely functional:

image

If you find a minimal reproduction, please raise a separate issue.

@SimenB
Copy link
Contributor

SimenB commented May 3, 2024

Fair enough 😀

#1405

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants