Fix walkObject to work with module namespace objects
#1368
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 3919a1c The changes in this PR will be included in the next version bump. This PR includes changesets to release 15 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
askoufis
force-pushed
the
namespace-theme-tokens
branch
from
7747cac
to
c56cfe5
Compare
askoufis
commented
Mar 21, 2024
| @@ -11,7 +11,7 @@ export function walkObject<T extends Walkable, MapTo>( | |||
| fn: (value: Primitive, path: Array<string>) => MapTo, | |||
| path: Array<string> = [], | |||
| ): MapLeafNodes<T, MapTo> { | |||
| const clone = obj.constructor(); | |||
| const clone = {} as any; | |||
There was a problem hiding this comment.
The types are a bit gnarly here, clone was any before this change, so this just keeps the status quo.
askoufis
force-pushed
the
namespace-theme-tokens
branch
from
ec52892
to
49ac0dd
Compare
michaeltaranto
approved these changes
Mar 28, 2024
Merged
|
Thank you everyone 👏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1360.
walkObjectdoesn't work on module namespace objects when running insidevite-node. This is because module namespace objects don't have aconstructorfunction.This "bug" has gone unnoticed for a long time because
esbuildwas modifying the export in some way that made it work, butvite-nodedoesn't seem to do this.I don't think we need to use
constructoranymore sincewalkObjectis constrained to only work on objects, at least as far as the type signature is concerned.