Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow hyphens inside css classes #1254

Merged
merged 6 commits into from
Jan 27, 2024
Merged

Allow hyphens inside css classes #1254

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
16a8d40
Fixes #1253
EvgenNoskov Dec 13, 2023
fac864f
don't escape hypen in regex
mrm007 Jan 27, 2024
e099ce5
Merge branch 'master' into master
mrm007 Jan 27, 2024
9251ad4
format
mrm007 Jan 27, 2024
0e71fbb
add a changeset
mrm007 Jan 27, 2024
c198842
fix site docs for webpack integration
mrm007 Jan 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions packages/css/src/identifier.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,6 +91,11 @@ describe('identifier', () => {
);
});

it('should allow hyphens in a class name', () => {
expect(generateIdentifier("a-b")).toMatchInlineSnapshot(`"abc_a-b_s0xkdr1_packagetest_file"`);
expect(generateIdentifier("a-b-c")).toMatchInlineSnapshot(`"abc_a-b-c_s0xkdr2_packagetest_file"`);
});

it('rejects invalid identifiers', () => {
// getIdentOption() does not remove spaces from the debug info so the
// resulting identifier should be invalid here.
Expand Down
2 changes: 1 addition & 1 deletion packages/css/src/identifier.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,7 @@ export function generateIdentifier(
packageName,
});

if (!identifier.match(/^[A-Z_][0-9A-Z_]+$/i)) {
if (!identifier.match(/^[A-Z_][0-9A-Z_\-]+$/i)) {
mrm007 marked this conversation as resolved.
Show resolved Hide resolved
throw new Error(
`Identifier function returned invalid indentifier: "${identifier}"`,
);
Expand Down