Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the resolved Next.js config in next-plugin #1099

Merged
merged 2 commits into from
May 26, 2023

Conversation

shuding
Copy link
Contributor

@shuding shuding commented May 26, 2023

Currently we're getting experimental flags (such as appDir) from the user config, nextConfig. This PR changes it to use the options.config argument of the webpack function instead. It's similar to nextConfig but it has all fallback values resolved as appDir now defaults to true.

Fixes #1087.

@changeset-bot
Copy link

changeset-bot bot commented May 26, 2023

🦋 Changeset detected

Latest commit: 6a9900b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@vanilla-extract/next-plugin Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@mattcompiles mattcompiles enabled auto-merge (squash) May 26, 2023 20:05
@mattcompiles mattcompiles merged commit 0d1c17a into vanilla-extract-css:master May 26, 2023
@shuding shuding deleted the resolved-config branch May 29, 2023 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Next.js 13 - experimental.appDir still being used in stable App Router
3 participants