feat: Convert dpl4hydra from shell script to C for performance #982
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Rewrite dpl4hydra.sh in C for improved performance and portability - Implement multi-threaded downloads for faster data retrieval - Add enhanced brand listing with pagination and search functionality - Improve error handling and memory management - Maintain original functionality while adding quality-of-life improvements
|
Build with:
|
| } | ||
|
|
||
| size_t write_callback(void *contents, size_t size, size_t nmemb, void *userp) { | ||
| size_t realsize = size * nmemb; |
| } | ||
|
|
||
| while (fgets(line, sizeof(line), input)) { | ||
| if (sscanf(line, "%[^,]", brand) == 1) { |
| free(brands); | ||
| exit(1); | ||
| } | ||
| strcpy(prev_brand, brand); |
|
Muito bom...parabéns
Em seg., 7 de out. de 2024 07:39, van Hauser ***@***.***>
escreveu:
… ***@***.**** commented on this pull request.
------------------------------
In dpl4hydra.c
<#982 (comment)>
:
> + free(brands);
+ exit(1);
+ }
+ brands = temp;
+ }
+ brands[brand_count] = strdup(brand);
+ if (!brands[brand_count]) {
+ fprintf(stderr, "Error: Memory allocation failed for brand.\n");
+ fclose(input);
+ for (int i = 0; i < brand_count; i++) {
+ free(brands[i]);
+ }
+ free(brands);
+ exit(1);
+ }
+ strcpy(prev_brand, brand);
buffer overflow
—
Reply to this email directly, view it on GitHub
<#982 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/A3X6TY25HIWRKEUL42W3VRDZ2JXI5AVCNFSM6AAAAABPOC2RWOVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDGNJRG4YDANJTGY>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
|
|
I'm putting the finishing touches on an update, coming your way soon. Is there anything else you'd like me to consider? I'm curious - do you find this feature valuable and worthwhile? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit significantly improves the functionality, performance, and user experience of the dpl4hydra tool, making it more efficient and easier to use for managing and generating default password lists.