Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1)timeout "-T" option fix. 2)Non-UTF characters in filenames now allowed. #7

Merged
merged 2 commits into from
Aug 25, 2022

Conversation

gvozdila
Copy link

Hello! I have 2 bugs&bugfixes.

  1. "timeout" applies after "cat", so "my_app @@", become "timeout cat filename | my_app @@".
    cat is usually very quick, so time out options now just don't work. This fix changes --verbose output too, now full command line will be printed.

  2. Problem with ".encode()". I tried fuzzing with "bash", and it shows very interesting behaviour. Sometimes files have strange names and produce strange errors. So afl-cov should deal with non-UTF names of files.
    And everything is ok, except encoding filename to UTF for logfile. Fixes it with replacing the unencodable character by its name, using errors="namereplace".

I hope it will help. Thank you!

Andrei Iakunin added 2 commits August 23, 2022 13:30
Timeout was applied after "cat @@|" and works only for "cat".
Now "--verbose" will print full command line, even with "timeout".
@vanhauser-thc
Copy link
Owner

sorry for the late reaction, I didnt get a notification.

@vanhauser-thc vanhauser-thc merged commit 9345417 into vanhauser-thc:master Aug 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants