Solve sonar code smells and apply improvements (#21) #27

	name: Sonar Analysis
	on:
	push:
	branches:
	- master
	pull_request:
	types: [opened, synchronize, reopened]
	jobs:
	build:
	name: Sonar Analysis
	runs-on: windows-latest
	steps:
	- name: Set up JDK 17
	uses: actions/setup-java@v3
	with:
	java-version: '17'
	distribution: 'temurin'
	- uses: actions/checkout@v2
	with:
	fetch-depth: 0
	- name: Cache SonarCloud packages
	uses: actions/cache@v1
	with:
	path: ~\sonar\cache
	key: ${{ runner.os }}-sonar
	restore-keys: ${{ runner.os }}-sonar
	- name: Cache SonarCloud scanner
	id: cache-sonar-scanner
	uses: actions/cache@v1
	with:
	path: .\.sonar\scanner
	key: ${{ runner.os }}-sonar-scanner
	restore-keys: ${{ runner.os }}-sonar-scanner
	- name: Install SonarCloud scanner
	if: steps.cache-sonar-scanner.outputs.cache-hit != 'true'
	shell: powershell
	run: \|
	New-Item -Path .\.sonar\scanner -ItemType Directory
	dotnet tool update dotnet-sonarscanner --tool-path .\.sonar\scanner
	- name: Build and analyze
	env:
	GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
	SONAR_TOKEN: ${{ secrets.SONAR_TOKEN }}
	shell: powershell
	run: \|
	.\.sonar\scanner\dotnet-sonarscanner begin /k:"vanderlan_Orion-Api" /o:"vanderlan-gomes" /d:sonar.token="${{ secrets.SONAR_TOKEN }}" /d:sonar.host.url="https://sonarcloud.io" /d:sonar.cs.opencover.reportsPaths="opencover.xml"
	dotnet build Orion.sln
	dotnet test /p:CollectCoverage=true /p:CoverletOutputFormat=opencover /p:CoverletOutput=coverage /p:Exclude=[xunit.] Orion.sln
	cp Orion.Test\coverage.opencover.xml opencover.xml
	.\.sonar\scanner\dotnet-sonarscanner end /d:sonar.token="${{ secrets.SONAR_TOKEN }}"

Provide feedback