chore: refactor Dockerfile setup for improved modularity and maintainability #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tnunamak
changed the title
Kahtaf
approved these changes
Mar 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Split up the monolithic
Dockerfileinto separate files for each build target (CPU,GPU,ARM64). Now when you build an image for a specific environment, it doesn't unnecessarily build the other targets.For example, if you're building the ARM64 image, it will use the common base but won't waste time building the GPU or CPU images. This saves time and resources, since you only build what you need.
The
Dockerfilesare also better organized now in their own directory, and the new build script makes it easy to build the specific image you want.This change makes our Docker setup more efficient and maintainable. Faster builds, less unnecessary work, cleaner structure.