Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add prefork utility #741

Merged
merged 18 commits into from
Feb 12, 2020
Merged

Add prefork utility #741

merged 18 commits into from
Feb 12, 2020

Conversation

savsgio
Copy link

@savsgio savsgio commented Feb 9, 2020

No description provided.

Sergio Andres Virviescas Santana added 3 commits February 9, 2020 16:40
erikdubbelboer
erikdubbelboer requested changes Feb 9, 2020
View reviewed changes
Copy link
Collaborator

@erikdubbelboer erikdubbelboer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the pull request. Some minor changes needed.
Can you also add a README that explains how this works and maybe some benchmarks which show the speed improvements. Thanks

prefork/prefork.go Outdated Show resolved Hide resolved
prefork/prefork.go Outdated Show resolved Hide resolved
prefork/prefork.go Outdated Show resolved Hide resolved
@savsgio
Copy link
Author

savsgio commented Feb 10, 2020

Thanks for the pull request. Some minor changes needed.
Can you also add a README that explains how this works and maybe some benchmarks which show the speed improvements. Thanks

Ok, i will do it.

@savsgio
Copy link
Author

savsgio commented Feb 10, 2020

README added!

erikdubbelboer
erikdubbelboer requested changes Feb 12, 2020
View reviewed changes
prefork/prefork.go Outdated Show resolved Hide resolved
prefork/prefork.go Outdated Show resolved Hide resolved
prefork/prefork.go Outdated Show resolved Hide resolved
savsgio
savsgio commented Feb 12, 2020
View reviewed changes
Copy link
Author

@savsgio savsgio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

Sergio Andres Virviescas Santana added 2 commits February 12, 2020 12:16
erikdubbelboer
erikdubbelboer requested changes Feb 12, 2020
View reviewed changes
Copy link
Collaborator

@erikdubbelboer erikdubbelboer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, some more changes requested.

prefork/prefork.go Outdated Show resolved Hide resolved
prefork/prefork.go Outdated Show resolved Hide resolved
prefork/prefork_test.go Outdated Show resolved Hide resolved
prefork/prefork.go Show resolved Hide resolved
Sergio Andrés Virviescas Santana and others added 5 commits February 12, 2020 12:39
@erikdubbelboer erikdubbelboer merged commit aa96a47 into valyala:master Feb 12, 2020
@erikdubbelboer
Copy link
Collaborator

Thanks!

@savsgio
Copy link
Author

savsgio commented Feb 12, 2020

Thanks for merge it 😃

@tsingson
Copy link

cool. thanks a lot.

i try! maybe i can use this to replace taskset + reuseport + multiple instance fasthttp serv.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erikdubbelboer erikdubbelboer erikdubbelboer requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@savsgio @erikdubbelboer @tsingson