add concurrency for client's HostClient map #1550
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
What is the use case for this? |
I have a api gateway app. I just want to add concurrency for client's HostClient map. what's wrong with the code？ |
erikdubbelboer
requested changes
May 5, 2023
client.go
Outdated
Comment on lines
314
to
322
| // GetHostClients return the map of Http HostClient | ||
| func (c *Client) GetHostClients() map[string]*HostClient { | ||
| return c.m | ||
| } | ||
|
|
||
| // GetHttpsHostClients return the map of Https HostClient | ||
| func (c *Client) GetHttpsHostClients() map[string]*HostClient { | ||
| return c.ms | ||
| } |
There was a problem hiding this comment.
Why add these methods? Since m and ms are protected by mLock it's impossible to use the return value of these functions in a safe way?
There was a problem hiding this comment.
This is test code. I will delete it
erikdubbelboer
requested changes
May 6, 2023
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.