-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add trailer support #1165
Add trailer support #1165
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lint is failing: https://github.com/valyala/fasthttp/runs/4310069291?check_suite_focus=true
Can you add some clear documentation that trailers are only supported with chunked bodies?
Sure. |
Seems the tests are a bit flaky. |
Yeah they are. You can ignore that. |
Sorry for asking for so many changes. I'm super happy that you wrote this code. But it's also quite a lot and important to get right I think. |
This is not a problem at all. It's always better to be strict with code. I have also learned a lot from this pr. |
Thanks! |
This is in reference to #1078 , #210 .
This will allow FastHTTP to support trailer for chunked transfers.
Write trailer
For example:
Header
Foo
will send after the chunked body.Read trailer
For example:
Trailer can be found by inspecting Header after reading all chunked body.