Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Fix server tests #6

Merged
merged 4 commits into from
Nov 1, 2021
Merged

test: Fix server tests #6

merged 4 commits into from
Nov 1, 2021

Conversation

colinkiama
Copy link
Member

tests/meson.build Outdated Show resolved Hide resolved
@colinkiama
Copy link
Member Author

All test pass now without any modifications made to the test executables.

Here's more info about the default -rpath behaviour changes: https://stackoverflow.com/questions/52018092/how-to-set-rpath-and-runpath-with-gcc-ld

@arteymix
Copy link
Member

arteymix commented Nov 1, 2021

So yeah, apparently -rpath now means -runpath. It's not transitive anymore, that's why the test binary is broken. Not that it is recommended though to use -rpath because it cannot be overwritten by the end-user.

We can address this differently though via pkg-config (maybe Lib.private? I need to review this) and redefining vsgi_dep to add the servers' folder to the dynamic linker. I'll merge this however since it address the regression.

Also your text editor is removing the last newline character of the file. We should copy over Valum's EditorConfig setup in this repository.

src/meson.build Outdated Show resolved Hide resolved
@arteymix
Copy link
Member

arteymix commented Nov 1, 2021

Also, you can create branches in this repo for PRs since you have the privileges for that. It's a bit more convenient for me if I want to checkout your code.

@colinkiama colinkiama requested a review from arteymix November 1, 2021 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants