-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Provide minimal support for Windows (fix #146) #198
base: master
Are you sure you want to change the base?
Conversation
9d52ea2
to
4562c01
Compare
d2a88aa
to
677e752
Compare
Codecov Report
@@ Coverage Diff @@
## master #198 +/- ##
==========================================
+ Coverage 62.39% 63.06% +0.66%
==========================================
Files 40 40
Lines 1367 1359 -8
Branches 170 166 -4
==========================================
+ Hits 853 857 +4
+ Misses 446 436 -10
+ Partials 68 66 -2
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #198 +/- ##
=========================================
Coverage ? 61.32%
=========================================
Files ? 44
Lines ? 1453
Branches ? 177
=========================================
Hits ? 891
Misses ? 499
Partials ? 63
Continue to review full report at Codecov.
|
677e752
to
389ed3a
Compare
74621b2
to
10170c6
Compare
Make both platform-dependant 'gio-unix-2.0' and 'gio-windows-2.0' dependencies optional and use features accordingly via 'GIO_UNIX' and 'GIO_WINDOWS' definitions. Use 'add_project_arguments' instead of 'vala_defines' Disable '--socket' option if 'gio-unix-2.0' is not available. For FastCGI, use 'GLib.Win32InputStream' and 'GLib.Win32OutputStream' and gracefully fallback with basic I/O wrapper. Add basic cross files to target 32 and 64 bit targets with MinGW.
224c8ce
to
936a0fd
Compare
4ab7ccf
to
d975f0f
Compare
Prefer the first over the latter if available and fallback with a platform-less implementation.
The output from the failed tests:
|
@ZanderBrown I'm aware of that :) I need to setup AppVeyor to automate the tests because I don't run Windows, though I really have no clue about doing that |
I have Windows on my computer, I can help on this if you want. 😃 |
@arteymix I suspected you where aware, my comment was intended more to show your progress (i.e. most stuff works). Built on Win10 32bit (MSYS2 MinGW) |
@Bat41 Good luck! Forking should be a no-op on non-supporting platform. Server errors might be related with dynamic loading of implementations. It's using The rule thing needs debugging. |
A further cause of issues maybe Windows Firewall which did popup during the tests (Admin permission is needed to publically open a port) |
Looks strange that you need admin right for using an unpriviledged port. It seems to me that tests are using 3003, no? |
In my experience opening any port to the wider network sets of Windows Firewall |
Here's what's remaining:
Server.fork