Story/document upload in bestandsdelen #1587
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 8 commits
July 11, 2024 13:36
Initial commit The code should be complete like this but I get an error during the put to bestandsdelen that the lock parameter is required, but it is provided with a filled value. Don't know yet what the issue is
Tried something new, still doesn't work
# Conflicts: # zgw/documenten-api/src/main/kotlin/com/ritense/documentenapi/DocumentenApiPlugin.kt # zgw/documenten-api/src/main/kotlin/com/ritense/documentenapi/client/DocumentenApiClient.kt
Switched over to RestClient, got it working
Switched over to RestClient, got it working
Now getting the lock from the bestandsdelen array and added tests
Added missing license headers
Now using the bestandsdelen to determine the amount and size of the chunks
…sdelen' into story/document-upload-in-bestandsdelen
Now using the correct bestandsdeel UUID for each chunk
Also fixed some sonarlint findings
zgw/documenten-api/src/main/kotlin/com/ritense/documentenapi/client/DocumentenApiClient.kt
Outdated
Show resolved
Hide resolved
…e file as a whole.
ivo-ritense
reviewed
Oct 8, 2024
zgw/documenten-api/src/main/kotlin/com/ritense/documentenapi/client/DocumentenApiClient.kt
Outdated
Show resolved
Hide resolved
Tom-Ritense
requested changes
Oct 8, 2024
zgw/documenten-api/src/main/kotlin/com/ritense/documentenapi/DocumentenApiPlugin.kt
Outdated
Show resolved
Hide resolved
zgw/documenten-api/src/main/kotlin/com/ritense/documentenapi/DocumentenApiPlugin.kt
Outdated
Show resolved
Hide resolved
zgw/documenten-api/src/main/kotlin/com/ritense/documentenapi/DocumentenApiPlugin.kt
Outdated
Show resolved
Hide resolved
zgw/documenten-api/src/main/kotlin/com/ritense/documentenapi/client/CreateDocumentResult.kt
Outdated
Show resolved
Hide resolved
zgw/documenten-api/src/main/kotlin/com/ritense/documentenapi/client/Bestandsdelen.kt
Outdated
Show resolved
Hide resolved
zgw/documenten-api/src/main/kotlin/com/ritense/documentenapi/client/DocumentenApiClient.kt
Outdated
Show resolved
Hide resolved
zgw/documenten-api/src/main/kotlin/com/ritense/documentenapi/client/DocumentenApiClient.kt
Outdated
Show resolved
Hide resolved
zgw/documenten-api/src/main/kotlin/com/ritense/documentenapi/client/DocumentenApiClient.kt
Outdated
Show resolved
Hide resolved
zgw/documenten-api/src/test/kotlin/com/ritense/documentenapi/client/DocumentenApiClientTest.kt
Outdated
Show resolved
Hide resolved
...documenten-api/src/test/kotlin/com/ritense/documentenapi/service/DocumentenApiServiceTest.kt
Outdated
Show resolved
Hide resolved
ivo-ritense
reviewed
Oct 8, 2024
zgw/documenten-api/src/main/kotlin/com/ritense/documentenapi/client/DocumentenApiClient.kt
Outdated
Show resolved
Hide resolved
ivo-ritense
reviewed
Oct 8, 2024
zgw/documenten-api/src/main/kotlin/com/ritense/documentenapi/client/DocumentenApiClient.kt
Outdated
Show resolved
Hide resolved
ivo-ritense
reviewed
Oct 8, 2024
zgw/documenten-api/src/main/kotlin/com/ritense/documentenapi/client/BestandsdelenRequest.kt
Outdated
Show resolved
Hide resolved
ivo-ritense
reviewed
Oct 8, 2024
zgw/documenten-api/src/main/kotlin/com/ritense/documentenapi/client/CreateDocumentResult.kt
Outdated
Show resolved
Hide resolved
ivo-ritense
reviewed
Oct 8, 2024
zgw/documenten-api/src/main/kotlin/com/ritense/documentenapi/client/CreateDocumentResult.kt
Show resolved
Hide resolved
…lient/DocumentenApiClient.kt Co-authored-by: Ivo Zaal <[email protected]>
Tom-Ritense
requested changes
Oct 10, 2024
zgw/documenten-api/src/main/kotlin/com/ritense/documentenapi/DocumentenApiPlugin.kt
Outdated
Show resolved
Hide resolved
zgw/documenten-api/src/main/kotlin/com/ritense/documentenapi/client/DocumentenApiClient.kt
Outdated
Show resolved
Hide resolved
added 2 commits
October 10, 2024 13:12
…sdelen' into story/document-upload-in-bestandsdelen
Tom-Ritense
previously approved these changes
Oct 10, 2024
ivo-ritense
reviewed
Oct 10, 2024
zgw/documenten-api/src/main/kotlin/com/ritense/documentenapi/DocumentenApiPlugin.kt
Outdated
Show resolved
Hide resolved
…ocumentenApiPlugin.kt
ivo-ritense
reviewed
Oct 10, 2024
zgw/documenten-api/src/main/kotlin/com/ritense/documentenapi/DocumentenApiPlugin.kt
Outdated
Show resolved
Hide resolved
ivo-ritense
reviewed
Oct 10, 2024
zgw/documenten-api/src/main/kotlin/com/ritense/documentenapi/DocumentenApiPlugin.kt
Show resolved
Hide resolved
…ocumentenApiPlugin.kt
ivo-ritense
reviewed
Oct 10, 2024
zgw/documenten-api/src/main/kotlin/com/ritense/documentenapi/DocumentenApiPlugin.kt
Outdated
Show resolved
Hide resolved
…ocumentenApiPlugin.kt
ivo-ritense
reviewed
Oct 10, 2024
zgw/documenten-api/src/main/kotlin/com/ritense/documentenapi/DocumentenApiPlugin.kt
Outdated
Show resolved
Hide resolved
…ocumentenApiPlugin.kt
ivo-ritense
reviewed
Oct 10, 2024
zgw/documenten-api/src/test/kotlin/com/ritense/documentenapi/DocumentenApiPluginTest.kt
Outdated
Show resolved
Hide resolved
…ocumentenApiPluginTest.kt
ivo-ritense
reviewed
Oct 10, 2024
zgw/documenten-api/src/test/kotlin/com/ritense/documentenapi/DocumentenApiPluginTest.kt
Outdated
Show resolved
Hide resolved
ivo-ritense
previously approved these changes
Oct 10, 2024
Rick-Ritense
commented
Oct 10, 2024
zgw/documenten-api/src/test/kotlin/com/ritense/documentenapi/client/DocumentenApiClientTest.kt
Outdated
Show resolved
Hide resolved
…lient/DocumentenApiClientTest.kt
Tom-Ritense
approved these changes
Oct 13, 2024
ivo-ritense
approved these changes
Oct 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the changes
Link to the related Github issue:
Relevant comments:
In Amsterdam there is a hard limit of 2 MB on POST calls which makes it impossible to upload files using the current document api method.
The documenten api also supports a "Bestandsdelen" method that allows a PUT call and uploading in chunks. This PR adds the new functionality
Breaking changes
Documentation
Link to the pull request in the Valtimo documentation repository:
New features or changes that have been introduced have been documented.
Tests
Unit tests have been added that cover these changes
Integration tests have been added that cover these changes
Security
The Secure by Default principle has been applied to these changes
Added or changed REST API endpoints have authentication and authorization in place
Valtimo access control checks have been implemented
Dependencies
Newly added dependencies do not introduce known vulnerabilities/CVE's and are in line with the Valtimo license