Jg0101 can remove user from room with admin

[jdg006]

let me know if you want me to change anything.

[jdg006]

Are the travis ci tests failing for anyone else or just me? I ask this because I am getting errors from files that were not in my pull request.

[valterbarros]

Ok's man I will review your code, Thank's

[valterbarros]

@jdg006 Actually github request to update some dependency on gemfile from project, and I need do this on master, one of the affected dependencies was rails-html-sanitizer, in the travis log he ask to you run bundle update rails-html-sanitizer. Try this and tell what happen.

[valterbarros]

Hey guy I like your code you did test woow awesome. But all actions from rooms are make via js or ajax, and in this code your remove user and redirect page to rooms_path this behavior is not cool. Can you do this remove without reload the page? Thank's if you have some doubts ask me.

[jdg006]

let me know if you want any other changes or if I need to rearrange any of the coffeescript files.

[valterbarros]

I test in my machine and is missing only little details. When you remove user if it is success I think is necessary return a response for user like a notification. To do this you can create a remove_user.js.erb to render a new notification with js helper new AppNotification(message, 2000).show_success_with_timeout() Remember this message need be a locale inside cofing/locales/en and config/locales/pt-br

en message: User removed with success
pt-br message: Usuário removido com sucesso

[jdg006]

Get Outlook for Android<https://aka.ms/ghei36>

…

________________________________ From: Valter Barros <[email protected]> Sent: Saturday, April 21, 2018 11:14:57 AM To: valterbarros/scrum-poker Cc: Gallagher, Joseph; Mention Subject: Re: [valterbarros/scrum-poker] Jg0101 can remove user from room with admin (#45) @valterbarros commented on this pull request. I test in my machine and is missing only little details. When you remove user if it is success I think is necessary return a response for user like a notification. To do this you can create a remove_user.js.erb to render a new notification with js helper new AppNotification(message, 2000).show_success_with_timeout() Remember this message need be a locale inside cofing/locales/en and config/locales/pt-br — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub<#45 (review)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/AbQLv-NxrwUn4s0bAYBqhPEtYlb0gbm7ks5tq0zxgaJpZM4TVTbv>.