-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Filtering stack trace #144
Merged
sergeykolbasov
merged 3 commits into
valskalla:master
from
lightning95:filtering-stack-trace
May 20, 2020
Merged
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
40 changes: 40 additions & 0 deletions
40
examples/src/main/scala/io/odin/examples/FilteringStackTrace.scala
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,40 @@ | ||
package io.odin.examples | ||
|
||
import cats.effect.{ExitCode, IO, IOApp} | ||
import io.odin._ | ||
import io.odin.formatter.Formatter | ||
import io.odin.formatter.options.ThrowableFormat | ||
|
||
/** | ||
* Filters stack trace of the thrown exception. | ||
* Prints: | ||
* ERROR io.odin.examples.FilteringStackTrace.run:39 - This is an exception | ||
* Caused by: java.lang.RuntimeException: here | ||
* io.odin.examples.FilteringStackTrace$.run(FilteringStackTrace.scala:39) | ||
* io.odin.examples.FilteringStackTrace$.main(FilteringStackTrace.scala:30) | ||
* io.odin.examples.FilteringStackTrace.main(FilteringStackTrace.scala) | ||
* " | ||
* | ||
* Instead of: | ||
* ERROR io.odin.examples.FilteringStackTrace.run:39 - This is an exception | ||
* Caused by: java.lang.RuntimeException: here | ||
* io.odin.examples.FilteringStackTrace$.run(FilteringStackTrace.scala:39) | ||
* cats.effect.IOApp.$anonfun$main$3(IOApp.scala:68) | ||
* cats.effect.internals.IOAppPlatform$.mainFiber(IOAppPlatform.scala:40) | ||
* cats.effect.internals.IOAppPlatform$.main(IOAppPlatform.scala:25) | ||
* cats.effect.IOApp.main(IOApp.scala:68) | ||
* cats.effect.IOApp.main$(IOApp.scala:67) | ||
* io.odin.examples.FilteringStackTrace$.main(FilteringStackTrace.scala:30) | ||
* io.odin.examples.FilteringStackTrace.main(FilteringStackTrace.scala) | ||
*/ | ||
object FilteringStackTrace extends IOApp { | ||
val throwableFormat: ThrowableFormat = ThrowableFormat( | ||
ThrowableFormat.Depth.Fixed(3), | ||
ThrowableFormat.Indent.NoIndent, | ||
ThrowableFormat.Filter.Excluding("cats.effect.IOApp", "cats.effect.internals.IOAppPlatform") | ||
) | ||
val logger: Logger[IO] = consoleLogger(formatter = Formatter.create(throwableFormat, colorful = true)) | ||
|
||
def run(args: List[String]): IO[ExitCode] = | ||
logger.error("This is an exception", new RuntimeException("here")).as(ExitCode.Success) | ||
} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would it be faster to move this check into
writeStackTrace
loop and save few allocations?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
then we'll need to move the
t.getStackTrace.take
part intowriteStackTrace
loop too, because we couldtake(5)
and then filter them out, having empty list of rows.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah, it's possible to just count amount of actual lines printed and stop whenever
depth
is achievedno worries, it's a matter of optimization in separate PR then
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can I make this PR for optimization?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@lightning95 sorry haven't noticed it earlier
yes, feel free to