Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix pricing #756

Merged
merged 10 commits into from
Sep 17, 2024
Merged

Fix pricing #756

merged 10 commits into from
Sep 17, 2024

Conversation

Adamantios
Copy link
Collaborator

Proposed changes

Fixes the pricing logic.

Fixes

Closes #735.

Types of changes

What types of changes does your code introduce to agents-aea?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

Put an x in the boxes that apply.

  • I have read the CONTRIBUTING doc
  • I am making a pull request against the develop branch (left side). Also you should start your branch off our develop.
  • Lint and unit tests pass locally with my changes and CI passes too
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that code coverage does not decrease.
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules

Further comments

n/a

Make the default priority fee optional and always apply it when present. Remove the unnecessary `priority_fee_estimation_trigger` which is causing issues with dynamic pricing.
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 90.90909% with 1 line in your changes missing coverage. Please review.

Project coverage is 90.09%. Comparing base (9d887d6) to head (7eb0ad9).
Report is 73 commits behind head on main.

Files with missing lines Patch % Lines
...ea-ledger-ethereum/aea_ledger_ethereum/ethereum.py 90.90% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #756      +/-   ##
==========================================
- Coverage   90.21%   90.09%   -0.13%     
==========================================
  Files         373      331      -42     
  Lines       29899    29567     -332     
==========================================
- Hits        26974    26638     -336     
- Misses       2925     2929       +4     
Flag Coverage Δ
unittests 90.09% <90.90%> (-0.13%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

0xArdi
0xArdi previously approved these changes Sep 17, 2024
solarw
solarw previously approved these changes Sep 17, 2024
@Adamantios Adamantios dismissed stale reviews from solarw and 0xArdi via 3a15c5d September 17, 2024 08:41
@Adamantios Adamantios merged commit f1e2e19 into main Sep 17, 2024
34 of 36 checks passed
@Adamantios Adamantios deleted the fix/pricing branch September 17, 2024 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Look into dynamic gas params
4 participants