Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add new Review component and apply it to SendConfirmation #6402

Closed
wants to merge 53 commits into from

fix knip

82c5c01
Select commit
Loading
Failed to load commit list.
Closed

feat: add new Review component and apply it to SendConfirmation #6402

fix knip
82c5c01
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Jan 21, 2025 in 0s

89.13% (target 75.00%)

View this Pull Request on Codecov

89.13% (target 75.00%)

Details

Codecov Report

Attention: Patch coverage is 97.74436% with 3 lines in your changes missing coverage. Please review.

Project coverage is 89.13%. Comparing base (80151ad) to head (82c5c01).

Files with missing lines Patch % Lines
src/send/SendConfirmation.tsx 96.82% 2 Missing ⚠️
src/components/TokenIcon.tsx 50.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #6402      +/-   ##
==========================================
+ Coverage   89.12%   89.13%   +0.01%     
==========================================
  Files         735      734       -1     
  Lines       31858    31900      +42     
  Branches     6054     6062       +8     
==========================================
+ Hits        28392    28435      +43     
- Misses       3271     3272       +1     
+ Partials      195      193       -2     
Files with missing lines Coverage Δ
src/account/utils.ts 100.00% <100.00%> (ø)
src/components/Avatar.tsx 100.00% <100.00%> (ø)
src/components/ContactCircle.tsx 100.00% <100.00%> (ø)
src/components/ReviewTransaction.tsx 100.00% <100.00%> (ø)
src/recipients/recipient.ts 78.90% <100.00%> (ø)
src/components/TokenIcon.tsx 96.87% <50.00%> (-3.13%) ⬇️
src/send/SendConfirmation.tsx 95.68% <96.82%> (-0.15%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 80151ad...82c5c01. Read the comment docs.