test(e2e): set up tests on mainnet #6229
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6229 +/- ##
==========================================
- Coverage 88.93% 88.92% -0.01%
==========================================
Files 737 737
Lines 31432 31432
Branches 5531 5839 +308
==========================================
- Hits 27955 27952 -3
+ Misses 3432 3280 -152
- Partials 45 200 +155
... and 66 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
| // verification step comes after restoring wallet, skip this step | ||
| await waitForElementId('PhoneVerificationSkipHeader') | ||
| await element(by.id('PhoneVerificationSkipHeader')).tap() | ||
| try { |
There was a problem hiding this comment.
Do we expect wallets to have no funds, or for PN verification to not be required? I think we'll have to skip PN verification every time, no? Should that be within a try/catch, or should we continue to fail if the attempt to skip it errors? Also when would we expect the "no funds" screen to appear? Shouldn't these wallets always have something?
There was a problem hiding this comment.
The wallet associated with WALLET_ADDRESS is verified, so it's expected there will not be a phone verification request. The wallet associated with WALLET_12_WORDS_ADDRESS does not have any funds, as no tests require this wallet to be funded. Given that the main focus of these tests is that we restore with 12- and 24-word mnemonics, these conditional skips seem fine to me.
Co-authored-by: Joe Bergeron <[email protected]>
Co-authored-by: Satish Ravi <[email protected]>
Description
Verify.spec&FiatConnectTransferOut.spec.js.Test plan
To test locally run populate the
e2e/example.envand rename fore2e/.env.Related issues
Backwards compatibility
Yes
Network scalability
Yes