Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: LeakCanary Removal #2874

Merged
merged 5 commits into from
Sep 14, 2022
Merged

chore: LeakCanary Removal #2874

merged 5 commits into from
Sep 14, 2022

Conversation

MuckT
Copy link
Collaborator

@MuckT MuckT commented Sep 14, 2022

Description

Removes LeakCanary. Some work was done with excluding classes as seen in c46372b; however, leaks were not properly ignored.

Other changes

N/A

Tested

Tested locally on Android

How others should test

This does not need to be tested by QA.

Related issues

Backwards compatibility

Yes

@linear
Copy link

linear bot commented Sep 14, 2022

RET-357 Spike: Leak Canary Class Ignore

LeakCanary is a memory leak detection library for Android that is used in development mode in Android. There are some known expected leaks such as those from react-native-screens.

These should be ignored to prevent false positives from being served from Leak Canary. - How to properly exclude a class (service) ?

AC:

  • Investigate and make a call on whether to fix or remove Leak Canary

@codecov
Copy link

codecov bot commented Sep 14, 2022

Codecov Report

Merging #2874 (f74d119) into main (238bdc8) will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2874   +/-   ##
=======================================
  Coverage   79.80%   79.81%           
=======================================
  Files         605      605           
  Lines       21888    21888           
  Branches     3996     3996           
=======================================
+ Hits        17468    17469    +1     
+ Misses       4370     4369    -1     
  Partials       50       50           
Impacted Files Coverage Δ
src/tokens/utils.ts 97.05% <0.00%> (+2.94%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 238bdc8...f74d119. Read the comment docs.

@MuckT MuckT merged commit ade0ff6 into main Sep 14, 2022
@MuckT MuckT deleted the tomm/leakcanary-removal branch September 14, 2022 18:50
@ValoraQA
Copy link

Hey @MuckT since NA is mentioned in how others should test section ,we are skipping this PR

Thanks.!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants