Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Append retried tests to index.html #2355

Merged
merged 12 commits into from
Apr 29, 2022
Merged

Conversation

MuckT
Copy link
Collaborator

@MuckT MuckT commented Apr 25, 2022

Description

Appends test results to index.html instead of overwriting on retries using the append option in the config.

Update - 1: There were some issues with using the append option in jest-html-reporter; hopefully, Hargne/jest-html-reporter#145 is approved and we can update to the latest version to resolve these issues.

Update - 2: The PR to jest-html-reporter was merged and the new version is used in this PR.

Other changes

N/A

Tested

Tested in CI.

How others should test

Does not need to be tested by QA. Reviewers should view the e2e test reports and check that all tests are present.

Related issues

N/A

Backwards compatibility

Yes

@codecov
Copy link

codecov bot commented Apr 25, 2022

Codecov Report

Merging #2355 (4207e38) into main (f49e213) will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2355   +/-   ##
=======================================
  Coverage   78.28%   78.29%           
=======================================
  Files         581      581           
  Lines       21149    21149           
  Branches     3884     3884           
=======================================
+ Hits        16557    16558    +1     
+ Misses       4529     4528    -1     
  Partials       63       63           
Impacted Files Coverage Δ
packages/mobile/src/tokens/utils.ts 94.11% <0.00%> (+2.94%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f49e213...4207e38. Read the comment docs.

@MuckT MuckT marked this pull request as draft April 25, 2022 23:09
@MuckT MuckT marked this pull request as ready for review April 27, 2022 15:28
@kathaypacific
Copy link
Collaborator

Hey @MuckT is this ready for review? sorry if i'm reviewing too early but i had a look at the artifacts generated for the e2e reports but they're not what i expected (e.g. the artifact in https://github.com/valora-inc/wallet/pull/2355/checks?check_run_id=6199595548) - is this the intended artifact? In particular, the index.html in src doesn't seem to be for the e2e tests and the src folder seems to contain the source files which are quite big (16.8mb and 700+ files) and not really needed, is there a way to omit them?

@MuckT
Copy link
Collaborator Author

MuckT commented Apr 28, 2022

@kathaypacific this is the correct link and there should be two separate downloads android-e2e-test-report and ios-e2e-test-report. It looks like the mobile tests results are also being named e2e, based on what you shared, but that's outside of the scope of this PR.

Copy link
Collaborator

@kathaypacific kathaypacific left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥳

@MuckT MuckT added the automerge Have PR merge automatically when checks pass label Apr 29, 2022
@mergify mergify bot merged commit c9eb4b1 into main Apr 29, 2022
@mergify mergify bot deleted the tomm/junit-html-reports-append branch April 29, 2022 15:46
@ValoraQA
Copy link

Hey @MuckT since Does not need to be tested by QA is mentioned in how other should test section , hence we are skipping the above PR

Thanks..!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Have PR merge automatically when checks pass Component: Tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants