Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable Dev builds with Xcode 13.1 #1323

Closed
wants to merge 6 commits into from
Closed

Enable Dev builds with Xcode 13.1 #1323

wants to merge 6 commits into from

Conversation

MuckT
Copy link
Collaborator

@MuckT MuckT commented Oct 27, 2021

Description

Enables builds with Xcode 13.1. Fix found in lugg/react-native-config#365 (comment).

Other changes

N/A

Tested

  • Debug and builds successful in Xcode 13.1 on Monterey.

How others should test

  • Create a debug build in Xcode 12.5 on Big Sur.
  • Create a release build in Xcode 12.5 on Big Sur.

Related issues

Backwards compatibility

Investigating

@codecov
Copy link

codecov bot commented Oct 27, 2021

Codecov Report

Merging #1323 (915bda9) into main (f585928) will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1323      +/-   ##
==========================================
- Coverage   75.35%   75.33%   -0.02%     
==========================================
  Files         532      532              
  Lines       19562    19562              
  Branches     3510     3510              
==========================================
- Hits        14741    14738       -3     
- Misses       4738     4741       +3     
  Partials       83       83              
Impacted Files Coverage Δ
packages/mobile/src/web3/saga.ts 69.93% <0.00%> (-1.85%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f585928...915bda9. Read the comment docs.

@MuckT MuckT changed the title Enable builds with Xcode 13.1 Enable Dev builds with Xcode 13.1 Oct 27, 2021
@MuckT
Copy link
Collaborator Author

MuckT commented Nov 4, 2021

For those attempting to run Xcode 12.5.1 in Monterey there is the following workaround:

  1. Download Xcode 12.5.1.
  2. Move it to your applications folder overwriting Xcode 13.1.
  3. Run from terminal with /Applications/Xcode.app/Contents/MacOS/Xcode.

@MuckT MuckT closed this Nov 11, 2021
@MuckT MuckT deleted the tomm/xcode-13 branch November 16, 2021 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enable builds in Xcode 13.1
1 participant