Updated: rxjs for typeahead component

[buchslava]

No description provided.

[valorkin]

#92 #89 #61 #41

[koodikindral]

Any progress with that?

[valorkin]

yeap, will be published

[Systho]

Any news on this PR ?

[valorkin]

this one most probably will not be merged
because extensive rxjs usage requires additional configuration
by ng2-bootstrap consumers

[Dinistro]

RxJS is in my opinion the way to go. If the async typeahead is used, the searching will mostly use http and this returns an Observable. Observables support a ton of very useful operators that can be used in the components.
I know that this will need some documentation for all the new consumers, but the current solution is not really practical.

[leon]

@valorkin Why would it require extra configuration?

if we import the operators distinctUntilChanged and debounceTime, they will be included, and the end user doesn't need to know about them.

[valorkin]

ok, need to try :)

[Dinistro]

@valorkin If you need a new pull request that works with rc.1, you can inform me. I will hopefuly have some time this weekend.

[valorkin]

Right now I am fighting with modals
If I win, when I win :)
Any other pop-ups stuff should be a breath
But I will appreciate any help :)

[Dinistro]

@valorkin Work is in progress. This will need some time to test all the stuff. As soon that I'm finished, I will open a new PR.

[valorkin]

@Dinistro awesome! I will try to finish modals today\tomorrow
today is my Birthday, so hard to say how much time I will have :)

[Dinistro]

@valorkin Happy birthday ;)
I'm finished with the work. Should I create the PR or should I wait until you merged the popup-stuff?

[valorkin]

I can give you write access so you can create a branch

On Mon, May 23, 2016, 12:24 Christian Ulmann [email protected]
wrote:

@valorkin https://github.com/valorkin Happy birthday ;)
I'm finished with the work. Should I create the PR or should I wait until
you merged the popup-stuff?

—
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
#99 (comment)

[Dinistro]

@valorkin Would be great. I will merge the changes from #535 into the new branch.

[valorkin]

@Dinistro welcome to ng2 team :)

[Dinistro]

This was merged in another PR: #584